[prev in list] [next in list] [prev in thread] [next in thread] 

List:       avro-dev
Subject:    Fwd: Generated code breaking change
From:       Christophe_Le_Saëc <chlesaec () gmail ! com>
Date:       2023-08-17 6:58:40
Message-ID: CADcRAfai5XM_AA3KF3JS96wqd2SNOuZA3PMH80FsLXq5xwsYrA () mail ! gmail ! com
[Download RAW message or body]


So, if there is no objection on this breaking (see AVRO-3749
<https://issues.apache.org/jira/browse/AVRO-3749>) change on generated
code, i will merge this PR <https://github.com/apache/avro/pull/2435> this
friday on afternoon.

Kind regards,
Christophe

---------- Forwarded message ---------
De : Martin Grigorov <mgrigorov@apache.org>
Date: ven. 11 août 2023 �  12:40
Subject: Re: Generated code breaking change
To: <dev@avro.apache.org>


On Thu, Aug 10, 2023 at 6:17 PM Oscar Westra van Holthe - Kind <
oscar@westravanholthe.nl> wrote:

> On Thu, 10 Aug 2023 at 15:30, Christophe Le Saëc <chlesaec@gmail.com>
> wrote:
>
> > The PR fix the issue but *comes with breaking change* in case of name
> > collision ('f' and 'F' are now transforms in getF() and getF$0() instead
> of
> > getF$0() and getF$1() as currently in main).
> >
> > So, is it acceptable changes considering it only occurs in case of name
> > conflict ?
> >
>
> As I have not encountered such naming collisions other than in very small
> numbers, so I think it's perfectly acceptable.
>

Agreed!
Even if it breaks someone's application I think it could be easily solved
by using an alias.


>
> Does anyone have different experiences?
>
>
> Kind regards,
> Oscar
>
> --
>
> ✉️ Oscar Westra van Holthe - Kind <oscar@westravanholthe.nl>
>


[prev in list] [next in list] [prev in thread] [next in thread]