[prev in list] [next in list] [prev in thread] [next in thread] 

List:       avro-dev
Subject:    [jira] Commented: (AVRO-642) Prettify the json dumped during exceptions while validating a writer/re
From:       "Doug Cutting (JIRA)" <jira () apache ! org>
Date:       2010-08-30 17:39:53
Message-ID: 8449204.71961283189993388.JavaMail.jira () thor
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/AVRO-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904265#action_12904265 \
] 

Doug Cutting commented on AVRO-642:
-----------------------------------

This causes Python unit tests to fail for me.  Also, can you please post this as a \
single patch file?  Thanks!

> Prettify the json dumped during exceptions while validating a writer/reader schema
> ----------------------------------------------------------------------------------
> 
> Key: AVRO-642
> URL: https://issues.apache.org/jira/browse/AVRO-642
> Project: Avro
> Issue Type: Improvement
> Components: java, python
> Affects Versions: 1.3.3
> Environment: Avro-Trunk
> Reporter: Harsh J Chouraria
> Assignee: Harsh J Chouraria
> Priority: Minor
> Fix For: 1.4.1
> 
> Attachments: avro.java.schema.pretty.r1.diff, avro.py.schema.pretty.r1.diff
> 
> Original Estimate: 0.02h
> Remaining Estimate: 0.02h
> 
> Right now the exception that's thrown when a reader and written schema don't match \
> (while reading a file), looks like this: {noformat}
> Found {"type":"record","name":"Test","fields":[{"name":"stringField","type":"string"},{"name":"longField","type":"long"}]}, \
> expecting {"type":"record","name":"Test1","fields":[{"name":"stringField","type":"string"},{"name":"longField","type":"long"}]}
>  {noformat}
> While this is perfectly okay for small schema with a few fields, it gets hard to \
> debug for complex and large ones. The attached patch changes the exception message \
> to look like: {noformat}
> Found {
> "type" : "record",
> "name" : "Test",
> "fields" : [ {
> "name" : "stringField",
> "type" : "string"
> }, {
> "name" : "longField",
> "type" : "long"
> } ]
> }, expecting {
> "type" : "record",
> "name" : "Test1",
> "fields" : [ {
> "name" : "stringField",
> "type" : "string"
> }, {
> "name" : "longField",
> "type" : "long"
> } ]
> }
> {noformat}
> P.s. Ideally a diff-like message would help too, but its mileage may vary. I guess \
> with the pretty output printed, a user may easily do a diff (since they now have \
> newlines), so us providing this is not _really_ needed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[prev in list] [next in list] [prev in thread] [next in thread]