[prev in list] [next in list] [prev in thread] [next in thread] 

List:       avro-dev
Subject:    Re: Review Request: AVRO-584 patch
From:       "Philip Zeyliger" <philip () cloudera ! com>
Date:       2010-06-23 23:26:36
Message-ID: 20100623232636.6647.10123 () ip-10-250-127-239 ! ec2 ! internal
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/225/#review272
-----------------------------------------------------------


A couple of nits on the documentation, but otherwise looks great.  When you=
 create your next patch, use --no-prefix in "git diff" to strip out the a/ =
and b/.  SVN folks prefer that.


lang/java/src/java/org/apache/avro/ipc/stats/Histogram.java
<http://review.hbase.org/r/225/#comment1134>

    If it's public, you may as well make your comment a javadoc.



lang/java/src/java/org/apache/avro/ipc/stats/Histogram.java
<http://review.hbase.org/r/225/#comment1135>

    I believe this is spelled "boundary" with plural "boundaries".



lang/java/src/java/org/apache/avro/ipc/stats/Histogram.java
<http://review.hbase.org/r/225/#comment1136>

    Mention that this keeps the last MAX_HISTORY_SIZE entries.  Are those r=
ecent entries in order?  If so, you should mention whether you intend to ke=
ep that promise in the javadoc.


- Philip


On 2010-06-23 16:17:21, Philip Zeyliger wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/225/
> -----------------------------------------------------------
> =

> (Updated 2010-06-23 16:17:21)
> =

> =

> Review request for Avro.
> =

> =

> Summary
> -------
> =

> Posting patch from http://review.hbase.org/r/225/
> =

> =

> Diffs
> -----
> =

>   lang/java/src/java/org/apache/avro/ipc/stats/Histogram.java 4f26f8b =

>   lang/java/src/java/org/apache/avro/ipc/stats/IntegerHistogram.java PRE-=
CREATION =

>   lang/java/src/test/java/org/apache/avro/ipc/stats/TestHistogram.java 52=
a36d1 =

> =

> Diff: http://review.hbase.org/r/225/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Philip
> =

>


[prev in list] [next in list] [prev in thread] [next in thread]