[prev in list] [next in list] [prev in thread] [next in thread] 

List:       avro-commits
Subject:    [1/3] avro git commit: AVRO-1688. Ruby test_union(TestIO) is failing.
From:       busbey () apache ! org
Date:       2017-04-12 3:37:11
Message-ID: cb02bd3cafe84622a7f04cc63d3d8390 () git ! apache ! org
[Download RAW message or body]

Repository: avro
Updated Branches:
  refs/heads/branch-1.7 ca5bdfd7a -> 835bcbacb


AVRO-1688. Ruby test_union(TestIO) is failing.

git-svn-id: https://svn.apache.org/repos/asf/avro/trunk@1690745 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 74b444929bfdbdd0bcdf45a80dec7b507f805428)


Project: http://git-wip-us.apache.org/repos/asf/avro/repo
Commit: http://git-wip-us.apache.org/repos/asf/avro/commit/ff2c83f4
Tree: http://git-wip-us.apache.org/repos/asf/avro/tree/ff2c83f4
Diff: http://git-wip-us.apache.org/repos/asf/avro/diff/ff2c83f4

Branch: refs/heads/branch-1.7
Commit: ff2c83f4406a8c00f9848d6897aec58cfd9e9851
Parents: ca5bdfd
Author: Thomas White <tomwhite@apache.org>
Authored: Mon Jul 13 16:19:22 2015 +0000
Committer: Sean Busbey <busbey@apache.org>
Committed: Tue Apr 11 22:35:38 2017 -0500

----------------------------------------------------------------------
 CHANGES.txt               |  2 ++
 lang/ruby/test/test_io.rb | 15 ++++++++++++++-
 2 files changed, 16 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/avro/blob/ff2c83f4/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index a06abda..c8fdaa0 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -36,6 +36,8 @@ Trunk (not yet released)
 
     AVRO-1813: Incorrect link to build instructions in Java Getting Started (Pietro Menna via gabor)
 
+    AVRO-1688. Ruby test_union(TestIO) is failing. (tomwhite)
+
 Avro 1.7.7 (23 July 2014)
 
   NEW FEATURES

http://git-wip-us.apache.org/repos/asf/avro/blob/ff2c83f4/lang/ruby/test/test_io.rb
----------------------------------------------------------------------
diff --git a/lang/ruby/test/test_io.rb b/lang/ruby/test/test_io.rb
index 2bf6ecf..f8f3da1 100644
--- a/lang/ruby/test/test_io.rb
+++ b/lang/ruby/test/test_io.rb
@@ -21,45 +21,55 @@ class TestIO < Test::Unit::TestCase
   Schema = Avro::Schema
 
   def test_null
+    check('"null"')
     check_default('"null"', "null", nil)
   end
 
   def test_boolean
+    check('"boolean"')
     check_default('"boolean"', "true", true)
     check_default('"boolean"', "false", false)
   end
 
   def test_string
+    check('"string"')
     check_default('"string"', '"foo"', "foo")
   end
 
   def test_bytes
+    check('"bytes"')
     check_default('"bytes"', '"foo"', "foo")
   end
 
   def test_int
+    check('"int"')
     check_default('"int"', "5", 5)
   end
 
   def test_long
+    check('"long"')
     check_default('"long"', "9", 9)
   end
 
   def test_float
+    check('"float"')
     check_default('"float"', "1.2", 1.2)
   end
 
   def test_double
+    check('"double"')
     check_default('"double"', "1.2", 1.2)
   end
 
   def test_array
     array_schema = '{"type": "array", "items": "long"}'
+    check(array_schema)
     check_default(array_schema, "[1]", [1])
   end
 
   def test_map
     map_schema = '{"type": "map", "values": "long"}'
+    check(map_schema)
     check_default(map_schema, '{"a": 1}', {"a" => 1})
   end
 
@@ -70,6 +80,7 @@ class TestIO < Test::Unit::TestCase
        "fields": [{"name": "f",
                    "type": "long"}]}
 EOS
+    check(record_schema)
     check_default(record_schema, '{"f": 11}', {"f" => 11})
   end
 
@@ -80,11 +91,13 @@ EOS
        "fields": [{"name": "message",
                    "type": "string"}]}
 EOS
+    check(error_schema)
     check_default(error_schema, '{"message": "boom"}', {"message" => "boom"})
   end
 
   def test_enum
     enum_schema = '{"type": "enum", "name": "Test","symbols": ["A", "B"]}'
+    check(enum_schema)
     check_default(enum_schema, '"B"', "B")
   end
 
@@ -129,6 +142,7 @@ EOS
 
   def test_fixed
     fixed_schema = '{"type": "fixed", "name": "Test", "size": 1}'
+    check(fixed_schema)
     check_default(fixed_schema, '"a"', "a")
   end
 
@@ -284,7 +298,6 @@ EOS
   private
 
   def check_default(schema_json, default_json, default_value)
-    check(schema_json)
     actual_schema = '{"type": "record", "name": "Foo", "fields": []}'
     actual = Avro::Schema.parse(actual_schema)
 

[prev in list] [next in list] [prev in thread] [next in thread]