[prev in list] [next in list] [prev in thread] [next in thread] 

List:       avro-commits
Subject:    svn commit: r1415558 - in /avro/trunk: CHANGES.txt lang/c/src/datum.c
From:       brucem () apache ! org
Date:       2012-11-30 9:39:41
Message-ID: 20121130093941.B485123889BF () eris ! apache ! org
[Download RAW message or body]

Author: brucem
Date: Fri Nov 30 09:39:40 2012
New Revision: 1415558

URL: http://svn.apache.org/viewvc?rev=1415558&view=rev
Log:
AVRO-1163: Fix memory leak in avro_fixed_private(). Contributed by Maxim Pugachev.

Modified:
    avro/trunk/CHANGES.txt
    avro/trunk/lang/c/src/datum.c

Modified: avro/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/avro/trunk/CHANGES.txt?rev=1415558&r1=1415557&r2=1415558&view=diff
 ==============================================================================
--- avro/trunk/CHANGES.txt (original)
+++ avro/trunk/CHANGES.txt Fri Nov 30 09:39:40 2012
@@ -82,6 +82,9 @@ Avro 1.7.3 (3 November 2012)
     AVRO-1175. Java: Clear thread local reference in BinaryData#compare().
     (cutting)
 
+    AVRO-1163. C: Fix a memory leak in avro_fixed_private(). (Maxim
+    Pugachev via brucem)
+
 Avro 1.7.2 (20 October 2012)
 
   NEW FEATURES

Modified: avro/trunk/lang/c/src/datum.c
URL: http://svn.apache.org/viewvc/avro/trunk/lang/c/src/datum.c?rev=1415558&r1=1415557&r2=1415558&view=diff
 ==============================================================================
--- avro/trunk/lang/c/src/datum.c (original)
+++ avro/trunk/lang/c/src/datum.c Fri Nov 30 09:39:40 2012
@@ -615,6 +615,7 @@ static avro_datum_t avro_fixed_private(a
 	check_param(NULL, is_avro_schema(schema), "schema");
 	struct avro_fixed_schema_t *fschema = avro_schema_to_fixed(schema);
 	if (size != fschema->size) {
+		avro_free((char *) bytes, size);
 		avro_set_error("Fixed size (%zu) doesn't match schema (%zu)",
 			       (size_t) size, (size_t) fschema->size);
 		return NULL;


[prev in list] [next in list] [prev in thread] [next in thread]