[prev in list] [next in list] [prev in thread] [next in thread] 

List:       autoconf
Subject:    Re: [gettext] changequote considered harmful
From:       Stepan Kasal <kasal () ucw ! cz>
Date:       2005-08-03 16:35:21
Message-ID: 20050803163521.GB7273 () math ! cas ! cz
[Download RAW message or body]

Hello,

On Tue, Aug 02, 2005 at 12:58:32PM +0200, Bruno Haible wrote:
> The style that fulfills goals 1 and 2 here is like this:
> 
>   [...
>     # Found it, now check the version.
>     ]AC_MSG_CHECKING([version of bison])[
>     ac_prog_version=`$INTLBISON --version 2>&1 | sed -n 's/^.*GNU Bison.* \([0-9]*\.[0-9.]*\).*$/\1/p'`
>     case $ac_prog_version in
>       '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;;
>       1.2[6-9]* | 1.[3-9][0-9]* | [2-9].*)
>          ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;;
>       *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;;
>     esac
>     ]AC_MSG_RESULT([$ac_prog_version])[
>   ...]
> 
> I.e. put braces around everything, but unbrace the macro invocations and
> don't put dnl comments.

I see nothing wrong with this style.  Please go ahead and use it.

I wouldn't use this pure style in _my_ macros.  Hey, I even omit the
pair of quotes for some of the arguments.

I don't think Autoconf should _require_ this style, but it could describe
it as the theoretically ideal style.  And it could point to gettext,
to show that there are monks which can live up to this ideal.   ;-)

Are you willing to submit a documentation patch?  (I hope Paul would
accept it.)

Have a nice day,
	Stean



[prev in list] [next in list] [prev in thread] [next in thread]