[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] Add missing XML tags in pjsip NOTIFY for RFC4235
From: George Joseph <gjoseph () digium ! com>
Date: 2017-10-24 19:20:12
Message-ID: CAP=uFEt_RNjc1akywCWwg52XhB7tqyBUPTmQ_U8XZnfn2K4m5w () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Fri, Oct 13, 2017 at 3:21 PM, Ludovic Gasc <gmludo@gmail.com> wrote:
> Hi,
>
> Certainly as you, we have more and more phone brands who are capable to
> read the XML from a NOTIFY when a phone rings to extract callerid and show
> that on the screen.
>
> The issue is that it doesn't work on chan_sip, not planned to be fixed:
> https://issues.asterisk.org/jira/browse/ASTERISK-24488
>
> Moreover, the situation is worse with pjsip, because we have less
> information:
> https://issues.asterisk.org/jira/browse/ASTERISK-26454
>
> For now, we have a backup plan with something similar of this:
> https://github.com/kettenbach-it/asterisk-snom-pickup-info-xml-agi
> But with a better scalability and based on AMI command MessageSend, to be
> NAT compliant: https://wiki.asterisk.org/wiki/display/AST/
> Asterisk+13+ManagerAction_MessageSend
>
> However, we have now an internal incentive to have an integrated solution
> directly in Asterisk.
>
> We have an internal C developer who can work on it full-time, but before
> to follow the rabbit in the hole, I'm pretty sure that if it was simply to
> enrich this function:
> https://github.com/asterisk/asterisk/blob/master/res/res_
> pjsip_dialog_info_body_generator.c#L101
> The patch was already made and merged a long time ago.
>
> Is it a way exists to implement that or it needs to re-implement a part of
> Asterisk ?
>
Hi Ludovic,
Yep, that's the place. dialog_info_generate_body_content is the function
you want to extend. Just don't modify any of the existing attributes and
if you need to add data fields to the ast_sip_exten_state_data structure
(or any public structure) make sure to do so at the end of the structure to
preserve binary compatibility.
> If somebody already has an idea about the path to follow to fix that, I'm
> interested in, to save our time of exploring.
>
> Thanks for your response.
> --
> Ludovic Gasc (GMLudo)
> Lead Developer Architect at ALLOcloud
> https://be.linkedin.com/in/ludovicgasc
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
> http://lists.digium.com/mailman/listinfo/asterisk-dev
>
--
George Joseph
Digium, Inc. | Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org
[Attachment #5 (text/html)]
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct \
13, 2017 at 3:21 PM, Ludovic Gasc <span dir="ltr"><<a \
href="mailto:gmludo@gmail.com" target="_blank">gmludo@gmail.com</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div \
dir="ltr">Hi,<div><br></div><div>Certainly as you, we have more and more phone brands \
who are capable to read the XML from a NOTIFY when a phone rings to extract callerid \
and show that on the screen.</div><div><br></div><div>The issue is that it \
doesn't work on chan_sip, not planned to be fixed:</div><div><a \
href="https://issues.asterisk.org/jira/browse/ASTERISK-24488" \
target="_blank">https://issues.asterisk.org/<wbr>jira/browse/ASTERISK-24488</a></div><div><br></div><div>Moreover, \
the situation is worse with pjsip, because we have less information:</div><div><a \
href="https://issues.asterisk.org/jira/browse/ASTERISK-26454" \
target="_blank">https://issues.asterisk.org/<wbr>jira/browse/ASTERISK-26454</a></div><div><br></div><div>For \
now, we have a backup plan with something similar of this: <a \
href="https://github.com/kettenbach-it/asterisk-snom-pickup-info-xml-agi" \
target="_blank">https://github.com/<wbr>kettenbach-it/asterisk-snom-<wbr>pickup-info-xml-agi</a></div><div>But \
with a better scalability and based on AMI command MessageSend, to be NAT compliant: \
<a href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+13+ManagerAction_MessageSend" \
target="_blank">https://wiki.<wbr>asterisk.org/wiki/display/AST/<wbr>Asterisk+13+ManagerAction_<wbr>MessageSend</a></div><div><br></div><div>However, \
we have now an internal incentive to have an integrated solution directly in \
Asterisk.</div><div><br></div><div>We have an internal C developer who can work on it \
full-time, but before to follow the rabbit in the hole, I'm pretty sure that if \
it was simply to enrich this function:</div><div><a \
href="https://github.com/asterisk/asterisk/blob/master/res/res_pjsip_dialog_info_body_generator.c#L101" \
target="_blank">https://github.com/asterisk/<wbr>asterisk/blob/master/res/res_<wbr>pjsip_dialog_info_body_<wbr>generator.c#L101</a></div><div>The \
patch was already made and merged a long time ago.</div><div><br></div><div>Is it a \
way exists to implement that or it needs to re-implement a part of Asterisk \
?</div></div></blockquote><div><br></div><div>Hi \
Ludovic,</div><div><br></div><div>Yep, that's the place. \
dialog_info_generate_body_content is the function you want to extend. Just \
don't modify any of the existing attributes and if you need to add data fields to \
the ast_sip_exten_state_data structure (or any public structure) make sure to do so \
at the end of the structure to preserve binary \
compatibility.</div><div><br></div><div><br></div><div> </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>If somebody already has an \
idea about the path to follow to fix that, I'm interested in, to save our time of \
exploring.</div><div><br></div><div>Thanks for your response.<br \
clear="all"><div><div class="gmail-m_-8635597709321143064gmail_signature"><div \
dir="ltr"><div><div dir="ltr">--<br><div style="font-size:small"><div>Ludovic Gasc \
(GMLudo)</div><div>Lead Developer Architect at ALLOcloud</div><div><a \
href="https://be.linkedin.com/in/ludovicgasc" \
target="_blank">https://be.linkedin.com/in/<wbr>ludovicgasc</a></div></div></div></div></div></div></div>
</div></div>
<br>--<br>
______________________________<wbr>______________________________<wbr>_________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" \
rel="noreferrer" target="_blank">http://www.api-digital.com</a> --<br> <br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" rel="noreferrer" \
target="_blank">http://lists.digium.com/<wbr>mailman/listinfo/asterisk-dev</a><br></blockquote></div><br><br \
clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><span \
style="font-size:12.8px">George Joseph</span><br style="font-size:12.8px"><span \
style="font-size:12.8px">Digium, Inc. | Software Developer</span><span \
style="font-size:12.8px"><br>445 Jan Davis Drive NW - Huntsville, AL 35806 - \
US<br></span><span style="font-size:12.8px">Check us out at: </span><a \
href="http://www.digium.com/" rel="noreferrer" \
style="color:rgb(17,85,204);font-size:12.8px" target="_blank">www.digium.com</a><span \
style="font-size:12.8px"> & </span><a href="http://www.asterisk.org/" \
rel="noreferrer" style="color:rgb(17,85,204);font-size:12.8px" \
target="_blank">www.asterisk.org</a><br><div><br></div></div></div> </div></div>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic