[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] app_queue.c PAUSALL/UNPAUSEALL reason
From: Richard Mudgett <rmudgett () digium ! com>
Date: 2016-10-22 0:48:11
Message-ID: CALD46g1+qvTELNFeFnJbD72rDh1KZa7GT=ji1WXQyStoTUbA5A () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Fri, Oct 21, 2016 at 5:46 PM, Troy Bowman <troy@lump.net> wrote:
>
> I always need to apply this patch before putting Asterisk into Production.
>
> The pauses for specific queues get the reason logged properly, but the
> pausealls don't. I rely on pausalls and their reasons for reporting,
> though I'm trying to get away from it by keeping agents in single queues.
>
> Can we get this in the pipeline somewhere? Do I have to submit a patch
> this tiny through gerrit?
>
> diff a/apps/app_queue.c b/apps/app_queue.c
> --- a/apps/app_queue.c
> +++ b/apps/app_queue.c
> @@ -7289,7 +7228,7 @@ static int set_member_paused(const char *queuename,
> const char *interface, const
> * but since this affects all
> queues, we cannot.
> */
> ast_queue_log("NONE", "NONE",
> mem->membername,
> - (paused ? "PAUSEALL" :
> "UNPAUSEALL"), "%s", "");
> + (paused ? "PAUSEALL" :
> "UNPAUSEALL"), "%s", S_OR(reason, ""));
> }
>
> set_queue_member_pause(q, mem, reason,
> paused);
>
>
All patches have to go through gerrit whether you submit it or someone else
does.
However, if you wait for someone else it may take awhile.
Richard
https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process
https://wiki.asterisk.org/wiki/display/AST/Code+Review
[Attachment #5 (text/html)]
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct \
21, 2016 at 5:46 PM, Troy Bowman <span dir="ltr"><<a href="mailto:troy@lump.net" \
target="_blank">troy@lump.net</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div>I always need \
to apply this patch before putting Asterisk into \
Production.</div><div><br></div><div>The pauses for specific queues get the reason \
logged properly, but the pausealls don't. I rely on pausalls and their reasons \
for reporting, though I'm trying to get away from it by keeping agents in single \
queues.</div><div><br></div><div>Can we get this in the pipeline somewhere? Do I \
have to submit a patch this tiny through gerrit?</div><div><br></div><div><div><font \
size="1" face="monospace, monospace">diff a/apps/app_queue.c \
b/apps/app_queue.c</font></div><div><span \
style="font-family:monospace,monospace;font-size:x-small">--- \
a/apps/app_queue.c</span><br></div><div><font size="1" face="monospace, \
monospace">+++ b/apps/app_queue.c</font></div></div><div><div><font size="1" \
face="monospace, monospace">@@ -7289,7 +7228,7 @@ static int set_member_paused(const \
char *queuename, const char *interface, const</font></div><div><font size="1" \
face="monospace, monospace"> \
* but since this affects all queues, we cannot.</font></div><div><font size="1" \
face="monospace, monospace"> \
*/</font></div><div><font size="1" face="monospace, monospace"> \
ast_queue_log("NONE", "NONE", \
mem->membername,</font></div><div><font size="1" face="monospace, monospace">- \
(paused ? "PAUSEALL" : "UNPAUSEALL"), "%s", \
"");</font></div><div><font size="1" face="monospace, monospace">+ \
(paused ? "PAUSEALL" : "UNPAUSEALL"), "%s", \
S_OR(reason, ""));</font></div><div><font size="1" face="monospace, \
monospace"> }</font></div><div><font \
size="1" face="monospace, monospace"> </font></div><div><font size="1" \
face="monospace, monospace"> \
set_queue_member_pause(q, mem, reason, \
paused);</font></div></div><div><br></div></div></blockquote><div><br></div><div>All \
patches have to go through gerrit whether you submit it or someone else \
does.<br></div><div>However, if you wait for someone else it may take \
awhile.<br></div><div><br></div><div>Richard<br></div></div><br><a \
href="https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process">https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process</a><br><a \
href="https://wiki.asterisk.org/wiki/display/AST/Code+Review">https://wiki.asterisk.org/wiki/display/AST/Code+Review</a><br><br></div></div>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic