[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] Icelandic numbers, dates and voicemail
From: Örn_Arnarson <orn () arnarson ! net>
Date: 2016-06-06 16:21:38
Message-ID: CAG_7Y1RHn9UDD-jxcF6KE4+2xbt5_Jt3mbV-EGtiZ_qbJUeonw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Thank you for the response, Mark.
I've opened a case in JIRA and submitted a patch in Gerrit. I hope I didn't
mess up too much in the process -- not familiar with the workflow of this
project or Gerrit at all.
JIRA: https://issues.asterisk.org/jira/browse/ASTERISK-26087
Gerrit: https://gerrit.asterisk.org/#/c/2946/
Regards,
=C3=96rn
On Tue, May 31, 2016 at 7:14 PM, Mark Michelson <mmichelson@digium.com>
wrote:
> I think you should feel free to submit this patch if you want it included
> in mainline Asterisk. If you are interested in submitting you patch, see
> https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage . That page
> details how to submit a patch to the Asterisk project.
>
> Just as a note, I don't think many of us are going to be able to properly
> analyze the usage of Icelandic. However, we will gladly check code
> correctness (i.e. it's not going to crash or anything).
>
> On Thu, May 26, 2016 at 12:50 PM, =C3=96rn Arnarson <orn@arnarson.net> wr=
ote:
>
>> Hello,
>>
>> I've patched say.c and app_voicemail.c of Asterisk version 13.9.0 to
>> support the Icelandic language w.r.t. dates and numbers. I was wondering
>> whether or not you guys would want this submitted into the codebase?
>> Icelandic is obviously a fringe language, so nobody else might use this,
>> ever. Still, I figured I'd ask in case people would be interested.
>>
>> The code is somewhat tested (has been running for years -- since
>> 1.6.2.17.2. I just ported it to 13.9.0 because we were upgrading), thoug=
h
>> of course we're probably not doing everything that's possible, so some
>> portions might be untested. However, everything we've tried seems to wor=
k
>> just fine (including very large numbers).
>>
>> I haven't submitted anything to the project before, so I don't know how
>> much of a bother it is. Presumably I'd have to patch the most recent
>> version of Asterisk in Git?
>>
>> Regards,
>> =C3=96rn
>>
>>
>>
>> --
>> _____________________________________________________________________
>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>>
>> asterisk-dev mailing list
>> To UNSUBSCRIBE or update options visit:
>> http://lists.digium.com/mailman/listinfo/asterisk-dev
>>
>
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
> http://lists.digium.com/mailman/listinfo/asterisk-dev
>
[Attachment #5 (text/html)]
<div dir="ltr"><div><div><div>Thank you for the response, Mark.<br><br></div>I've \
opened a case in JIRA and submitted a patch in Gerrit. I hope I didn't mess up \
too much in the process -- not familiar with the workflow of this project or Gerrit \
at all.<br><br></div><div>JIRA: <a \
href="https://issues.asterisk.org/jira/browse/ASTERISK-26087">https://issues.asterisk.org/jira/browse/ASTERISK-26087</a><br></div><div>Gerrit: \
<a href="https://gerrit.asterisk.org/#/c/2946/">https://gerrit.asterisk.org/#/c/2946/</a><br></div><div><br></div>Regards,<br></div>Örn<br></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Tue, May 31, 2016 at 7:14 PM, \
Mark Michelson <span dir="ltr"><<a href="mailto:mmichelson@digium.com" \
target="_blank">mmichelson@digium.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">I think you should feel free to submit this \
patch if you want it included in mainline Asterisk. If you are interested in \
submitting you patch, see <a \
href="https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage" \
target="_blank">https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage</a> . That \
page details how to submit a patch to the Asterisk project.<div><br></div><div>Just \
as a note, I don't think many of us are going to be able to properly analyze the \
usage of Icelandic. However, we will gladly check code correctness (i.e. it's not \
going to crash or anything).</div></div><div class="gmail_extra"><br><div \
class="gmail_quote"><div><div class="h5">On Thu, May 26, 2016 at 12:50 PM, Örn \
Arnarson <span dir="ltr"><<a href="mailto:orn@arnarson.net" \
target="_blank">orn@arnarson.net</a>></span> wrote:<br></div></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div><div class="h5"><div \
dir="ltr"><div><div><div>Hello,<br><br></div>I've patched say.c and \
app_voicemail.c of Asterisk version 13.9.0 to support the Icelandic language w.r.t. \
dates and numbers. I was wondering whether or not you guys would want this submitted \
into the codebase? Icelandic is obviously a fringe language, so nobody else might use \
this, ever. Still, I figured I'd ask in case people would be \
interested.<br><br>The code is somewhat tested (has been running for years -- since \
1.6.2.17.2. I just ported it to 13.9.0 because we were upgrading), though of course \
we're probably not doing everything that's possible, so some portions might \
be untested. However, everything we've tried seems to work just fine (including \
very large numbers).<br><br></div>I haven't submitted anything to the project \
before, so I don't know how much of a bother it is. Presumably I'd have to \
patch the most recent version of Asterisk in \
Git?<br><br></div><div>Regards,<br></div><div>Örn<br></div><div><br><br></div></div> \
<br></div></div><span class="HOEnZb"><font color="#888888">--<br> \
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" \
rel="noreferrer" target="_blank">http://www.api-digital.com</a> --<br> <br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" rel="noreferrer" \
target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></font></span></blockquote></div><br></div>
<br>--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" \
rel="noreferrer" target="_blank">http://www.api-digital.com</a> --<br> <br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" rel="noreferrer" \
target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br></div>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic