[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] =?utf-8?q?q931=2Ec=3A_Fix_DISCONNECT_Progress_Indi?= =?utf-8?q?cator_ie_handling=2E_=
From:       Richard Mudgett <asteriskteam () digium ! com>
Date:       2016-03-16 21:14:21
Message-ID: gerrit.1458162861794.Ic88aafb45053146b5701d666e6212f7555573624 () gerrit ! asterisk ! org
[Download RAW message or body]

Richard Mudgett has uploaded a new change for review.

  https://gerrit.asterisk.org/2426

Change subject: q931.c: Fix DISCONNECT Progress Indicator ie handling.
......................................................................

q931.c: Fix DISCONNECT Progress Indicator ie handling.

There are two scenarios that are exposed by DISCONNECT not initializing
the progress indicator value before processing the message when the
chan_dahdi.conf inbanddisconnect=yes option is set.

1) If a DISCONNECT comes in without a Progress Indicator ie and an earlier
message (such as SETUP-ACKNOWLEDGE or PROCEEDING) came in with the
indicator #8 (Inband audio present) then the DISCONNECT would not cause an
immediate hangup.  We would be letting the user hear the inband audio even
though there isn't any.

2) If a DISCONNECT message comes in with the indicator #8 (Inband audio
present) and then later the DISCONNECT message is repeated without a
Progress Indicator ie we would still ignore the second DISCONNECT to let
the user hear inband audio even though it likely isn't there anymore.

PRI-180 #close
Reported by: Alexandr Dranchuk

Change-Id: Ic88aafb45053146b5701d666e6212f7555573624
---
M q931.c
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/libpri refs/changes/26/2426/1

diff --git a/q931.c b/q931.c
index 69c210e..52afb3c 100644
--- a/q931.c
+++ b/q931.c
@@ -7381,6 +7381,8 @@
 		c->cause = -1;
 		c->causecode = -1;
 		c->causeloc = -1;
+		c->progress = -1;
+		c->progressmask = 0;
 		c->aoc_units = -1;
 		pri_schedule_del(ctrl, c->retranstimer);
 		c->retranstimer = 0;

-- 
To view, visit https://gerrit.asterisk.org/2426
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic88aafb45053146b5701d666e6212f7555573624
Gerrit-PatchSet: 1
Gerrit-Project: libpri
Gerrit-Branch: 1.4
Gerrit-Owner: Richard Mudgett <rmudgett@digium.com>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]