'Re: [asterisk-dev] [RTP] Detecting that a packet is SRTP'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [RTP] Detecting that a packet is SRTP
From:       Sean Bright <sean.bright () gmail ! com>
Date:       2015-04-29 16:18:07
Message-ID: 5541043F.2010901 () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

On 4/29/2015 11:20 AM, Yousf Ateya wrote:
> In res_rtp_asterisk.c, to detect that a packet is SRTP (not RTP), this 
> check is done (link to gitweb 
> <http://git.asterisk.org/gitweb/?p=asterisk/asterisk.git;a=blob;f=res/res_rtp_asterisk.c;h=62601dcadaaf011a692a247d66ec590b3b47edfa;hb=refs/heads/master#l2019>):
>  
> if ((*in >= 20) && (*in <= 64)) {
> 
> Although in the Datagram Transport Layer Security (DTLS) Extension to 
> Establish Keys for the Secure Real-time Transport Protocol (SRTP), 
> section 5.1.2 <https://tools.ietf.org/html/rfc5764#section-5.1.2> it 
> is stated that it should be between 20 and 63 (not 64).
> 
> Is this a bug?

Certainly appears to be.

Kind regards,
Sean

[Attachment #5 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 4/29/2015 11:20 AM, Yousf Ateya
      wrote:<br>
    </div>
    <blockquote
cite="mid:CAFoy26d7CuhAxUEB6454Ui=+EY_Urc3FP3U27DN3vuOGOdfeKQ@mail.gmail.com"
      type="cite">In res_rtp_asterisk.c, to detect that a packet is SRTP
      (not RTP), this check is done (<a moz-do-not-send="true"
href="http://git.asterisk.org/gitweb/?p=asterisk/asterisk.git;a=blob;f=res/res_rtp_ast \
erisk.c;h=62601dcadaaf011a692a247d66ec590b3b47edfa;hb=refs/heads/master#l2019">link  \
to gitweb</a>):<br>  <blockquote><span id="goog_965289813"></span>if ((*in &gt;= 20)
        &amp;&amp; (*in &lt;= 64)) {<span id="goog_965289814"></span><br>
      </blockquote>
      Although in the <a moz-do-not-send="true"
        href="https://tools.ietf.org/html/rfc5764#section-5.1.2">Datagram

        Transport Layer Security (DTLS) Extension to Establish Keys for
        the Secure Real-time Transport Protocol (SRTP), section 5.1.2</a>
      it is stated that it should be between 20 and 63 (not 64).<br>
      <div>
        <div><br>
        </div>
        <div>Is this a bug?</div>
      </div>
    </blockquote>
    <br>
    Certainly appears to be.<br>
    <br>
    Kind regards,<br>
    Sean<br>
  </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 