[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests
From: "jbigelow" <reviewboard () asterisk ! org>
Date: 2015-02-27 4:45:16
Message-ID: 20150227044516.28521.96704 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4452/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-24586
https://issues.asterisk.org/jira/browse/ASTERISK-24586
Repository: testsuite
Description
-------
This adds some local and non-local channel subscription tests for ARI. These tests \
ensure ARI events occur and/or don't occur for the appropriate stasis app(s). Due to \
the variations and small differences of these, the test-config.yaml descriptions of \
each is the best way to describe what they do.
Four tests have been added under \
'tests/rest_api/applications/channel-subscriptions/'. :
* originate_to_dialplan/non_local_channels - Similiar to the existing test that this \
patch modifies as mentioned below. This required modifying pjsua_mod.py to allow more \
calls.
* originate_to_other_stasis_app/local_channels - Creates two websockets, one for for \
each stasis app. Originates a local channel from AppA where half is sent into AppB \
and the other half send into the dialplan.
* originate_to_other_stasis_app/non_local_channels - Creates two websockets, one for \
for each stasis app. Originates a PJSIP channel from AppA to a pjsua phone where is \
is placed into AppB.
* originate_to_stasis_app/local_channels
Note: The test 'tests/rest_api/applications/subscribe-channel' test has been renamed \
to 'basic-subscribe' under the same location as the new tests.
The following test has been modified to ensure no ARI events are received:
* tests/rest_api/channels/originate_to_dialplan
Diffs
-----
/asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml 6475 \
/asterisk/trunk/tests/rest_api/applications/tests.yaml 6475
/asterisk/trunk/tests/rest_api/applications/subscribe-channel/test-config.yaml 6475 \
/asterisk/trunk/tests/rest_api/applications/subscribe-channel/subscribe_channel.py \
6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/configs/ast1/extensions.conf \
6475 /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/pjsip.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/http.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/http.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/pjsip.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6475
Diff: https://reviewboard.asterisk.org/r/4452/diff/
Testing
-------
* Executed each test successfully 30+ times.
* Changed the code to force a failure to ensure tests properly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4452/">https://reviewboard.asterisk.org/r/4452/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By jbigelow.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24586">ASTERISK-24586</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds some local and non-local channel subscription tests for ARI. \
These tests ensure ARI events occur and/or don't occur for the appropriate stasis \
app(s). Due to the variations and small differences of these, the test-config.yaml \
descriptions of each is the best way to describe what they do.
Four tests have been added under \
'tests/rest_api/applications/channel-subscriptions/'. :
* originate_to_dialplan/non_local_channels - Similiar to the existing test that this \
patch modifies as mentioned below. This required modifying pjsua_mod.py to allow more \
calls.
* originate_to_other_stasis_app/local_channels - Creates two websockets, one for for \
each stasis app. Originates a local channel from AppA where half is sent into AppB \
and the other half send into the dialplan.
* originate_to_other_stasis_app/non_local_channels - Creates two websockets, one for \
for each stasis app. Originates a PJSIP channel from AppA to a pjsua phone where is \
is placed into AppB.
* originate_to_stasis_app/local_channels
Note: The test 'tests/rest_api/applications/subscribe-channel' test has been \
renamed to 'basic-subscribe' under the same location as the new tests.
The following test has been modified to ensure no ARI events are received:
* tests/rest_api/channels/originate_to_dialplan</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Executed each test successfully 30+ times.
* Changed the code to force a failure to ensure tests properly failed.
* Review logs to ensure operation is as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml \
<span style="color: grey">(6475)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/tests.yaml <span style="color: \
grey">(6475)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/subscribe-channel/test-config.yaml \
<span style="color: grey">(6475)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/subscribe-channel/subscribe_channel.py \
<span style="color: grey">(6475)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/subscribe-channel/configs/ast1/extensions.conf \
<span style="color: grey">(6475)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/tests.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/tests.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/tests.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/pjsip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/http.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/http.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/tests.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/pjsip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/pjsua_mod.py <span style="color: \
grey">(6475)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4452/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic