[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4443: dial api: add self destruction option
From: "Scott Griepentrog" <reviewboard () asterisk ! org>
Date: 2015-02-26 18:53:15
Message-ID: 20150226185315.3579.44793 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4443/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 12:53 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
-------
Committed in revision 432385
Repository: Asterisk
Description
-------
This adds a self-destruction ability to the dial api. The usefulness of this is \
mostly when using async mode to spawn a separate thread to handle the new call, while \
the calling thread is allowed to go on about other business. The alternative of this \
option is that the calling thread must either hang around for the duration or spawn \
it's own thread in order to create and then later destroy the dial structure after \
the call completes.
Example (minus error checking):
struct ast_dial *dial = ast_dial_create();
ast_dial_append(dial, "PJSIP", "200", NULL);
ast_dial_option_global_enable(dial, AST_DIAL_OPTION_ANSWER_EXEC, "Echo");
ast_dial_option_global_enable(dial, AST_DIAL_OPTION_SELF_DESTROY, NULL);
ast_dial_run(dial, NULL, 1);
The dial_run call returns almost immediately after spawning a new thread to complete \
and monitor the dial. If the call is answered, it is put into echo. When completed, \
ast_dial_destroy() will be called on the dial structure.
Note that any allocations made to pass values to ast_dial_set_user_data() or other \
dial options will need to be free'd in a state callback function on any of \
AST_DIAL_RESULT_UNASWERED, AST_DIAL_RESULT_ANSWERED, AST_DIAL_RESULT_HANGUP, or \
AST_DIAL_RESULT_TIMEOUT.
Diffs
-----
/branches/13/main/dial.c 432173
/branches/13/include/asterisk/dial.h 432173
Diff: https://reviewboard.asterisk.org/r/4443/diff/
Testing
-------
Correct operation confirmed with a temporary test function running under valgrind to \
insure there are no invalid references or leaks.
Thanks,
Scott Griepentrog
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4443/">https://reviewboard.asterisk.org/r/4443/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Scott Griepentrog.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2015, 12:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 432385</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds a self-destruction ability to the dial api. The usefulness of \
this is mostly when using async mode to spawn a separate thread to handle the new \
call, while the calling thread is allowed to go on about other business. The \
alternative of this option is that the calling thread must either hang around for the \
duration or spawn it's own thread in order to create and then later destroy the \
dial structure after the call completes.
Example (minus error checking):
struct ast_dial *dial = ast_dial_create();
ast_dial_append(dial, "PJSIP", "200", NULL);
ast_dial_option_global_enable(dial, AST_DIAL_OPTION_ANSWER_EXEC, "Echo");
ast_dial_option_global_enable(dial, AST_DIAL_OPTION_SELF_DESTROY, NULL);
ast_dial_run(dial, NULL, 1);
The dial_run call returns almost immediately after spawning a new thread to complete \
and monitor the dial. If the call is answered, it is put into echo. When completed, \
ast_dial_destroy() will be called on the dial structure.
Note that any allocations made to pass values to ast_dial_set_user_data() or other \
dial options will need to be free'd in a state callback function on any of \
AST_DIAL_RESULT_UNASWERED, AST_DIAL_RESULT_ANSWERED, AST_DIAL_RESULT_HANGUP, or \
AST_DIAL_RESULT_TIMEOUT. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Correct operation confirmed with a temporary test function running under \
valgrind to insure there are no invalid references or leaks. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/main/dial.c <span style="color: grey">(432173)</span></li>
<li>/branches/13/include/asterisk/dial.h <span style="color: \
grey">(432173)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4443/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic