'Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase
From:       "rnewton" <reviewboard () asterisk ! org>
Date:       2015-02-25 23:48:28
Message-ID: 20150225234828.23218.19648 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/
-----------------------------------------------------------

(Updated Feb. 25, 2015, 5:48 p.m.)

Status
------

This change has been marked as submitted.

Review request for Asterisk Developers.

Changes
-------

Committed in revision 432301

Repository: Asterisk

Description
-------

One of things discussed at the last AstriDevCon was better documentation (for \
everything!), but in particular, we mentioned needing some example configurations \
that pertain to a real-world scenario. That is, as opposed to the current "sample" \
files which are sort of all over the place at this point.

This patch proposes a basic and minimal configuration of Asterisk to satisfy the \
requirements for the first phase of Super Awesome Company's implementation of \
Asterisk.

I will submit four separate patches for the first phase, so that we don't have to \
review the entire thing all at once. This review is for the first patch.

Who is Super Awesome Company? See \
https://wiki.asterisk.org/wiki/display/AST/Super+Awesome+Company

For the first patch, I am attempting to satisfy the below requirements. The patch \
does not include a new make target, as I believe Matt Jordan offered to handle that.

SAC requires:

    * PJSIP connectivity for all employee desk phones.
    * The ability for employees to call one another inside of the office.
    * Voicemail boxes for each of the employees.

"Basic" configuration

We want SAC to have a clean system. That means:

    * No 'autoload' in modules.conf. Explicitly load a basic configuration. If SAC \
                doesn't need the module, don't load it.
    * Every module loaded should have a configuration file that is appropriate for \
it. This includes all the 'core' things that need configuration.

pjsip.conf

    * A PJSIP configuration for their desk phones. Assume every endpoint that is a \
                phone has:
        * A voicemail mailbox that they can subscribe to
        * A hint for their device
        * Note that the PJSIP configuration should adhere to best practices. That \
means MAC addresses for device names, etc.

extensions.conf

    * A safe dialplan for intra-company communication. This should be templated out \
so that it is trivial to add additional devices (use pattern matching/pattern \
                matching hints, etc.)
    * Receiving a Busy/Unavailable should result in going to VoiceMail
    * A user should be able to dial something and get to their VoiceMailMain without \
                having to enter in their extension number 
    * Note that mapping of MAC address endpoints to extension numbers should be done \
in some fashion that is easily extensible.

voicemail.conf

    * Set up mailboxes for every person in SAC. Assign 'default' pins. Create \
                reasonable basic settings.
    * Do not set up e-mail or pager addresses.

REVIEW?

Please, if possible look at this from a few angles:

 * Use the configuration, configure a couple phones and call between them. Leave \
                voicemails and retrieve them.
 * Have I created any security issues?
 * Is my dialplan easy to understand?
 * Could anything be done more efficiently without making it over-complicated?
 * Have I over-complicated anything?
 * Are there any critical settings I'm missing from any of the files?

A couple, more specific questions:

 * We have sample configs in /configs/samples; what directory do we want these \
                configurations in? (I used /configs/examples for now, but I don't \
                really like it)
 * We have the make target "make samples" for the current samples; what do we want \
for these new configs?

Diffs
-----

  /branches/13/configs/examples/awesome/voicemail.conf PRE-CREATION 
  /branches/13/configs/examples/awesome/pjsip.conf PRE-CREATION 
  /branches/13/configs/examples/awesome/musiconhold.conf PRE-CREATION 
  /branches/13/configs/examples/awesome/modules.conf PRE-CREATION 
  /branches/13/configs/examples/awesome/logger.conf PRE-CREATION 
  /branches/13/configs/examples/awesome/indications.conf PRE-CREATION 
  /branches/13/configs/examples/awesome/extensions.conf PRE-CREATION 
  /branches/13/configs/examples/awesome/asterisk.conf PRE-CREATION 
  /branches/13/configs/examples/awesome/README PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/4379/diff/

Testing
-------

Setup Asterisk with configuration, connected up three phones using the first three \
users. Made calls between them all, left voicemails and retrieved them with all \
users. Verified MWI working with all phones.

Thanks,

rnewton

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/4379/">https://reviewboard.asterisk.org/r/4379/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By rnewton.</div>

<p style="color: grey;"><i>Updated Feb. 25, 2015, 5:48 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 432301</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">One of things discussed at the last AstriDevCon was better documentation \
(for everything!), but in particular, we mentioned needing some example \
configurations that pertain to a real-world scenario. That is, as opposed to the \
current &quot;sample&quot; files which are sort of all over the place at this point.

This patch proposes a basic and minimal configuration of Asterisk to satisfy the \
requirements for the first phase of Super Awesome Company&#39;s implementation of \
Asterisk.

I will submit four separate patches for the first phase, so that we don&#39;t have to \
review the entire thing all at once. This review is for the first patch.