[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.
From: "George Joseph" <reviewboard () asterisk ! org>
Date: 2015-01-30 18:16:02
Message-ID: 20150130181602.16042.38843 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4383/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 11:16 a.m.)
Review request for Asterisk Developers.
Changes
-------
Updated to address Scott's concerns...
The default application was removed. If not specified, no app is added.
The documentation was updated and links to the wiki page added.
Repository: Asterisk
Description (updated)
-------
Looking at the Super Awesome Company sample reminded me that creating hints is just \
plain gruntwork. So you can now have the pjsip conifg wizard auto-create them for \
you.
Specifying 'hint_exten' in the wizard will create 'exten => \
<hint_exten>,hint/PJSIP/<wizard_id>' in whatever is specified for 'hint_context'. \
Specifying 'hint_application' in the wizard will create 'exten => \
<hint_exten>,1,<hint_application>' in whatever is specified for 'hint_context'.
The default for 'hint_context' is the endpoint's context.
There's no default for 'hint_application'. If not specified, no app is added.
There's no default for 'hint_exten'. If not specified, neither the hint itself nor \
the application will be created.
Some may think this is the slippery slope to users.conf but hints are a basic \
necessity for phones unlike voicemail, manager, etc that users.conf creates.
Diffs (updated)
-----
branches/13/res/res_pjsip_config_wizard.c 431494
branches/13/configs/samples/pjsip_wizard.conf.sample 431494
Diff: https://reviewboard.asterisk.org/r/4383/diff/
Testing
-------
Existing config_wizard testsuite tests pass.
Additional testsuite tests in the works.
Thanks,
George Joseph
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4383/">https://reviewboard.asterisk.org/r/4383/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By George Joseph.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2015, 11:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated to address Scott's concerns... The default application was \
removed. If not specified, no app is added. The documentation was updated and links \
to the wiki page added. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looking at the Super Awesome Company sample reminded me that creating \
hints is just plain gruntwork. So you can now have the pjsip conifg wizard \
auto-create them for you.
Specifying 'hint_exten' in the wizard will create 'exten => \
<hint_exten>,hint/PJSIP/<wizard_id>' in whatever is specified for \
'hint_context'. Specifying 'hint_application' in the wizard will \
create 'exten => <hint_exten>,1,<hint_application>' in \
whatever is specified for 'hint_context'.
The default for 'hint_context' is the endpoint's context.
There's no default for 'hint_application'. If not specified, no app is \
added. There's no default for 'hint_exten'. If not specified, neither \
the hint itself nor the application will be created.
Some may think this is the slippery slope to users.conf but hints are a basic \
necessity for phones unlike voicemail, manager, etc that users.conf creates.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Existing config_wizard testsuite tests pass. Additional testsuite tests \
in the works. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>branches/13/res/res_pjsip_config_wizard.c <span style="color: \
grey">(431494)</span></li>
<li>branches/13/configs/samples/pjsip_wizard.conf.sample <span style="color: \
grey">(431494)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4383/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic