[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4293: testsuite: Add a test for PJSIP keep alive packets for connec
From: "Matt Jordan" <reviewboard () asterisk ! org>
Date: 2014-12-24 12:53:23
Message-ID: 20141224125323.11115.98003 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4293/
-----------------------------------------------------------
(Updated Dec. 24, 2014, 6:53 a.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
-------
Committed in revision 6134
Repository: testsuite
Description
-------
This patch adds a test for the PJSIP keep_alive_interval option. It sets the \
keep_alive_interval to 2 seconds, makes a TCP client connection to the PJSIP stack, \
and then waits for 5 keep alives. Upon receiving 5 packets, it disconnects and stops \
the test.
In all cases, the test verifies on stopping:
* That 5 total packets were received
* That the time deltas between packets were received within approximately 2 seconds \
of each other
* That the keep alive values are all '\r\n\r\n'
Note that this test is being written for two reasons:
(1) Because tests are good
(2) So that the revision that added the keep_alive_interval option can be backported \
to Asterisk 13. As it turns out, having keep alives for connection oriented \
transports is super useful under certain non-ideal yet depressingly common network \
conditions.
Diffs
-----
/asterisk/trunk/tests/channels/pjsip/tests.yaml 6133
/asterisk/trunk/tests/channels/pjsip/keep_alive/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/keep_alive/keep_alive.py PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/keep_alive/configs/ast1/pjsip.conf \
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4293/diff/
Testing
-------
Thanks,
Matt Jordan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4293/">https://reviewboard.asterisk.org/r/4293/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Dec. 24, 2014, 6:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 6134</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a test for the PJSIP keep_alive_interval option. It sets \
the keep_alive_interval to 2 seconds, makes a TCP client connection to the PJSIP \
stack, and then waits for 5 keep alives. Upon receiving 5 packets, it disconnects and \
stops the test.
In all cases, the test verifies on stopping:
* That 5 total packets were received
* That the time deltas between packets were received within approximately 2 seconds \
of each other
* That the keep alive values are all '\r\n\r\n'
Note that this test is being written for two reasons:
(1) Because tests are good
(2) So that the revision that added the keep_alive_interval option can be backported \
to Asterisk 13. As it turns out, having keep alives for connection oriented \
transports is super useful under certain non-ideal yet depressingly common network \
conditions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: \
grey">(6133)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/keep_alive/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/keep_alive/keep_alive.py <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/keep_alive/configs/ast1/pjsip.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4293/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic