'[asterisk-dev] [Code Review] 4212: res_pjsip_endpoint_identified_ip: Add 'show identify' and 'show i'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] [Code Review] 4212: res_pjsip_endpoint_identified_ip: Add 'show identify' and 'show i
From:       "George Joseph" <reviewboard () asterisk ! org>
Date:       2014-11-24 19:35:12
Message-ID: 20141124193512.27047.24023 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4212/
-----------------------------------------------------------

Review request for Asterisk Developers.

Repository: Asterisk

Description
-------

While troubleshooting other things I realized there were no pjsip cli commands for \
identify.  This patch adds them.  It also also fixes a reference leak when a 'show \
endpoint' displayed identifies and properly sets the return code if load_module can't \
allocate a cli formatter structure.

Diffs
-----

  branches/12/res/res_pjsip_endpoint_identifier_ip.c 428600 
  branches/12/res/res_pjsip/pjsip_cli.c 428600 

Diff: https://reviewboard.asterisk.org/r/4212/diff/

Testing
-------

Made sure the cli commands produce the expected output.

Thanks,

George Joseph

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/4212/">https://reviewboard.asterisk.org/r/4212/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By George Joseph.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While troubleshooting other things I realized there were no pjsip cli \
commands for identify.  This patch adds them.  It also also fixes a reference leak \
when a &#39;show endpoint&#39; displayed identifies and properly sets the return code \
if load_module can&#39;t allocate a cli formatter structure.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Made sure the cli commands produce the expected output.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/12/res/res_pjsip_endpoint_identifier_ip.c <span style="color: \
grey">(428600)</span></li>

 <li>branches/12/res/res_pjsip/pjsip_cli.c <span style="color: \
grey">(428600)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/4212/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 