[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4201: app_record: prevent stripping 1/4 second audio when channel i
From: "Matt Jordan" <reviewboard () asterisk ! org>
Date: 2014-11-24 17:04:31
Message-ID: 20141124170431.20861.88201 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4201/#review13847
-----------------------------------------------------------
Ship it!
/trunk/apps/app_record.c
<https://reviewboard.asterisk.org/r/4201/#comment24326>
The SVN commit message will reference the issue, so there's no need to place it \
in the comment here.
Other than that, this looks good. This issue can get cleaned up on commit.
- Matt Jordan
On Nov. 21, 2014, 3:56 a.m., Ben Smithurst wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4201/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 3:56 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-24530
> https://issues.asterisk.org/jira/browse/ASTERISK-24530
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> We are encountering a problem recording using the Record app with 'k' option, and \
> hanging up to end the recording, as Asterisk is stripping 1/4 second from the end. \
> This is breaking some of our automated tests which record/playback audio and so on. \
> It is not clear why this stripping is done but the best guess seems to be related \
> to stripping DTMF tones, as it is NOT done if the recording is ended by timeout, \
> and the code pre-dates the 'k' option.
> This patch should maintain existing behaviour for DTMF termination and timeouts, \
> but prevent stripping in the 'hangup' case.
>
> Diffs
> -----
>
> /trunk/apps/app_record.c 428525
>
> Diff: https://reviewboard.asterisk.org/r/4201/diff/
>
>
> Testing
> -------
>
> Our in-house automated tests which compare audio are much happier with this patch. \
> No problems observed with DTMF termination of recordings either.
> To clarify we have tested this on 11.9.0, I have submitted the patch against trunk, \
> it applies to either.
>
> Thanks,
>
> Ben Smithurst
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4201/">https://reviewboard.asterisk.org/r/4201/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/4201/diff/1/?file=69154#file69154line456" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/apps/app_record.c</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
int record_exec(struct ast_channel *chan, const char *data)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">456</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"><span class="tb"> </span><span class="tb"> </span> * \
https://issues.asterisk.org/jira/browse/ASTERISK-24530</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The SVN \
commit message will reference the issue, so there's no need to place it in the \
comment here.
Other than that, this looks good. This issue can get cleaned up on commit.</pre>
</div>
<br />
<p>- Matt Jordan</p>
<br />
<p>On November 21st, 2014, 3:56 a.m. CST, Ben Smithurst wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Ben Smithurst.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2014, 3:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24530">ASTERISK-24530</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We are encountering a problem recording using the Record app with \
'k' option, and hanging up to end the recording, as Asterisk is stripping 1/4 \
second from the end. This is breaking some of our automated tests which \
record/playback audio and so on.
It is not clear why this stripping is done but the best guess seems to be related to \
stripping DTMF tones, as it is NOT done if the recording is ended by timeout, and the \
code pre-dates the 'k' option.
This patch should maintain existing behaviour for DTMF termination and timeouts, but \
prevent stripping in the 'hangup' case.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Our in-house automated tests which compare audio are much happier with \
this patch. No problems observed with DTMF termination of recordings either.
To clarify we have tested this on 11.9.0, I have submitted the patch against trunk, \
it applies to either.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_record.c <span style="color: grey">(428525)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4201/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic