'Re: [asterisk-dev] [Code Review] 4204: Failure showing codecs via 'core show channeltype <tech>''

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 4204: Failure showing codecs via 'core show channeltype <tech>'
From:       "Joshua Colp" <reviewboard () asterisk ! org>
Date:       2014-11-24 11:51:46
Message-ID: 20141124115146.4922.98654 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4204/#review13844
-----------------------------------------------------------

Ship it!

Ship It!

- Joshua Colp

On Nov. 24, 2014, 12:18 a.m., Brad Latus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4204/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 12:18 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24542
>     https://issues.asterisk.org/jira/browse/ASTERISK-24542
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> As per bug, extend the size of the ast_str to 256.
> 
> This allows us plenty of room to cater for more codecs in the future.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/channel.c 427839 
> 
> Diff: https://reviewboard.asterisk.org/r/4204/diff/
> 
> 
> Testing
> -------
> 
> ast> core show channeltype SIP
> 
> Now works without error of 'failed to extend from 64 to 98'
> 
> 
> Thanks,
> 
> Brad Latus
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/4204/">https://reviewboard.asterisk.org/r/4204/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Joshua Colp</p>

<br />
<p>On November 24th, 2014, 12:18 a.m. UTC, Brad Latus wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Brad Latus.</div>

<p style="color: grey;"><i>Updated Nov. 24, 2014, 12:18 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-24542">ASTERISK-24542</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As per bug, extend the size of the ast_str to 256.

This allows us plenty of room to cater for more codecs in the future.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ast&gt; core show channeltype SIP

Now works without error of &#39;failed to extend from 64 to 98&#39;</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/main/channel.c <span style="color: grey">(427839)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/4204/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 