'Re: [asterisk-dev] [Code Review] 4201: Prevent app_record stripping 1/4 second audio when channel is'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 4201: Prevent app_record stripping 1/4 second audio when channel is
From:       "Ben Smithurst" <reviewboard () asterisk ! org>
Date:       2014-11-21 9:52:16
Message-ID: 20141121095216.16304.91752 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4201/
-----------------------------------------------------------

(Updated Nov. 21, 2014, 9:52 a.m.)

Review request for Asterisk Developers.

Bugs: ASTERISK-24530
    https://issues.asterisk.org/jira/browse/ASTERISK-24530

Repository: Asterisk

Description
-------

We are encountering a problem recording using the Record app with 'k' option, and \
hanging up to end the recording, as Asterisk is stripping 1/4 second from the end.  \
This is breaking some of our automated tests which record/playback audio and so on.

It is not clear why this stripping is done but the best guess seems to be related to \
stripping DTMF tones, as it is NOT done if the recording is ended by timeout, and the \
code pre-dates the 'k' option.

This patch should maintain existing behaviour for DTMF termination and timeouts, but \
prevent stripping in the 'hangup' case.

Diffs
-----

  /trunk/apps/app_record.c 428525 

Diff: https://reviewboard.asterisk.org/r/4201/diff/

Testing (updated)
-------

Our in-house automated tests which compare audio are much happier with this patch.  \
No problems observed with DTMF termination of recordings either.

To clarify we have tested this on 11.9.0, I have submitted the patch against trunk, \
it applies to either.

Thanks,

Ben Smithurst

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/4201/">https://reviewboard.asterisk.org/r/4201/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Ben Smithurst.</div>

<p style="color: grey;"><i>Updated Nov. 21, 2014, 9:52 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-24530">ASTERISK-24530</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We are encountering a problem recording using the Record app with \
&#39;k&#39; option, and hanging up to end the recording, as Asterisk is stripping 1/4 \
second from the end.  This is breaking some of our automated tests which \
record/playback audio and so on.

It is not clear why this stripping is done but the best guess seems to be related to \
stripping DTMF tones, as it is NOT done if the recording is ended by timeout, and the \
code pre-dates the &#39;k&#39; option.

This patch should maintain existing behaviour for DTMF termination and timeouts, but \
prevent stripping in the &#39;hangup&#39; case.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Our in-house automated tests which compare audio are much happier with \
this patch.  No problems observed with DTMF termination of recordings either.

To clarify we have tested this on 11.9.0, I have submitted the patch against trunk, \
it applies to either.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/apps/app_record.c <span style="color: grey">(428525)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/4201/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 