'Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 4196: bridge_basic: Fix features issues introduced by review 4167
From:       "Matt Jordan" <reviewboard () asterisk ! org>
Date:       2014-11-21 2:17:02
Message-ID: 20141121021702.29842.23207 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4196/
-----------------------------------------------------------

(Updated Nov. 20, 2014, 8:17 p.m.)

Status
------

This change has been marked as submitted.

Review request for Asterisk Developers and Joshua Colp.

Changes
-------

Committed in revision 428505

Repository: Asterisk

Description
-------

In https://reviewboard.asterisk.org/r/4167, two bugs were introduced:

* Prior to entering the features retry loop, the buffer that holds the collected \
digits is wiped. However, this inadvertently wipes out the first collected digit on \
the first pass through, which is obtained in ast_stream_and_wait. This caused all of \
                the features tests to fail.
* If ast_app_dtget returns a hangup (-1), the loop would retry incorrectly. If we \
detect a hangup, we have to stop trying the feature.

This patch fixes both issues.

Diffs
-----

  /branches/13/main/bridge_basic.c 428298 

Diff: https://reviewboard.asterisk.org/r/4196/diff/

Testing
-------

Tested with the atxfer_nominal test. Prior to this patch it would fail; with this \
patch it completes successfully.

Thanks,

Matt Jordan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/4196/">https://reviewboard.asterisk.org/r/4196/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers and Joshua Colp.</div>
<div>By Matt Jordan.</div>

<p style="color: grey;"><i>Updated Nov. 20, 2014, 8:17 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 428505</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In https://reviewboard.asterisk.org/r/4167, two bugs were introduced:

* Prior to entering the features retry loop, the buffer that holds the collected \
digits is wiped. However, this inadvertently wipes out the first collected digit on \
the first pass through, which is obtained in ast_stream_and_wait. This caused all of \
                the features tests to fail.
* If ast_app_dtget returns a hangup (-1), the loop would retry incorrectly. If we \
detect a hangup, we have to stop trying the feature.

This patch fixes both issues.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with the atxfer_nominal test. Prior to this patch it would fail; \
with this patch it completes successfully.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/13/main/bridge_basic.c <span style="color: grey">(428298)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/4196/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 