[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4128: func_jitterbuffer: fix frame leaks
From: "rmudgett" <reviewboard () asterisk ! org>
Date: 2014-10-31 17:44:30
Message-ID: 20141031174430.13786.88108 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4128/#review13652
-----------------------------------------------------------
Ship it!
Ship It!
- rmudgett
On Oct. 31, 2014, 12:20 p.m., Corey Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4128/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2014, 12:20 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-22409
> https://issues.asterisk.org/jira/browse/ASTERISK-22409
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> These changes are not controversial and fix a memory leak so they are now split from r3603.
>
> In 12+ these changes apply to main/abstract_js.c instead of funcs/func_jitterbuffer.c.
>
>
> Diffs
> -----
>
> /branches/11/main/abstract_jb.c 426593
> /branches/11/funcs/func_jitterbuffer.c 426593
>
> Diff: https://reviewboard.asterisk.org/r/4128/diff/
>
>
> Testing
> -------
>
> tests/funcs/func_jitterbuffer against 13 no longer leaks.
>
>
> Thanks,
>
> Corey Farrell
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4128/">https://reviewboard.asterisk.org/r/4128/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- rmudgett</p>
<br />
<p>On October 31st, 2014, 12:20 p.m. CDT, Corey Farrell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Corey Farrell.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2014, 12:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22409">ASTERISK-22409</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">These changes are not controversial and fix a memory leak so they are \
now split from r3603.
In 12+ these changes apply to main/abstract_js.c instead of \
funcs/func_jitterbuffer.c.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tests/funcs/func_jitterbuffer against 13 no longer leaks.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/main/abstract_jb.c <span style="color: grey">(426593)</span></li>
<li>/branches/11/funcs/func_jitterbuffer.c <span style="color: \
grey">(426593)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4128/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic