[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4136: testsuite: Add escaped semicolons tests for UpdateConfig and
From: "George Joseph" <reviewboard () asterisk ! org>
Date: 2014-10-31 17:14:11
Message-ID: 20141031171411.11478.27498 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4136/
-----------------------------------------------------------
(Updated Oct. 31, 2014, 11:14 a.m.)
Review request for Asterisk Developers.
Changes
-------
Changed string concats to os.path.join and cleaned up patch file.
Repository: testsuite
Description
-------
These are the testsuite tests for https://reviewboard.asterisk.org/r/4132/
They are dependent on https://reviewboard.asterisk.org/r/4134/ being committed first.
tests/manager/config/advanced/test-config.yaml was already in trunk, I just moved it.
Diffs (updated)
-----
asterisk/trunk/tests/pbx/tests.yaml 5831
asterisk/trunk/tests/pbx/dialplan_save/test-config.yaml PRE-CREATION
asterisk/trunk/tests/pbx/dialplan_save/run-test PRE-CREATION
asterisk/trunk/tests/pbx/dialplan_save/configs/ast1/extensions.conf PRE-CREATION
asterisk/trunk/tests/manager/tests.yaml 5831
asterisk/trunk/tests/manager/config/tests.yaml PRE-CREATION
asterisk/trunk/tests/manager/config/test-config.yaml 5831
asterisk/trunk/tests/manager/config/basic/test-config.yaml PRE-CREATION
asterisk/trunk/tests/manager/config/advanced/test-config.yaml PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4136/diff/
Testing
-------
The tests fail for non patched installs and pass for r4132 patched installs.
Thanks,
George Joseph
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4136/">https://reviewboard.asterisk.org/r/4136/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By George Joseph.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2014, 11:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed string concats to os.path.join and cleaned up patch file. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">These are the testsuite tests for \
https://reviewboard.asterisk.org/r/4132/ They are dependent on \
https://reviewboard.asterisk.org/r/4134/ being committed first.
tests/manager/config/advanced/test-config.yaml was already in trunk, I just moved it.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The tests fail for non patched installs and pass for r4132 patched \
installs. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/pbx/tests.yaml <span style="color: grey">(5831)</span></li>
<li>asterisk/trunk/tests/pbx/dialplan_save/test-config.yaml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/pbx/dialplan_save/run-test <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/pbx/dialplan_save/configs/ast1/extensions.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/manager/tests.yaml <span style="color: \
grey">(5831)</span></li>
<li>asterisk/trunk/tests/manager/config/tests.yaml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/manager/config/test-config.yaml <span style="color: \
grey">(5831)</span></li>
<li>asterisk/trunk/tests/manager/config/basic/test-config.yaml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/manager/config/advanced/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4136/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic