[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4116: res_pjsip: incorrect qualify statistics after disabling for c
From: "Kevin Harwell" <reviewboard () asterisk ! org>
Date: 2014-10-30 17:16:37
Message-ID: 20141030171637.18729.2690 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4116/
-----------------------------------------------------------
(Updated Oct. 30, 2014, 12:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers and Mark Michelson.
Changes
-------
Committed in revision 426755
Bugs: ASTERISK-24462
https://issues.asterisk.org/jira/browse/ASTERISK-24462
Repository: Asterisk
Description
-------
When removing the qualify_frequency from an AoR or a contact the statistics shown \
when issuing "pjsip show aors" from the CLI are incorrect. This patch deletes the \
contact's status object from sorcery, disassociating it from the contact, if the \
qualify_freqency is removed from configuration.
Diffs
-----
branches/12/res/res_pjsip/pjsip_options.c 426251
Diff: https://reviewboard.asterisk.org/r/4116/diff/
Testing
-------
Using static and dynamic contacts and various combinations of adding, removing, and \
reloading the configuration for both AoR and contact level qualify_freqency options \
noted that the qualify statistics are now correctly reflected.
Thanks,
Kevin Harwell
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4116/">https://reviewboard.asterisk.org/r/4116/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2014, 12:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 426755</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24462">ASTERISK-24462</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When removing the qualify_frequency from an AoR or a contact the \
statistics shown when issuing "pjsip show aors" from the CLI are incorrect. \
This patch deletes the contact's status object from sorcery, disassociating it \
from the contact, if the qualify_freqency is removed from configuration.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using static and dynamic contacts and various combinations of adding, \
removing, and reloading the configuration for both AoR and contact level \
qualify_freqency options noted that the qualify statistics are now correctly \
reflected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/res/res_pjsip/pjsip_options.c <span style="color: \
grey">(426251)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4116/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic