[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 4013: Alembic: Add 'outgoing' enum value to sippeers directmedia en
From: "rmudgett" <reviewboard () asterisk ! org>
Date: 2014-09-30 20:49:45
Message-ID: 20140930204945.25614.90246 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4013/#review13421
-----------------------------------------------------------
Ship it!
Minor nits
Before committing for each branch it's going into be sure to check if there are \
conflicts in the alembic node chain. \
https://wiki.asterisk.org/wiki/display/AST/Merging+alembic+scripts
/branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py
<https://reviewboard.asterisk.org/r/4013/#comment23945>
Should add the standard license header to the file.
/branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py
<https://reviewboard.asterisk.org/r/4013/#comment23944>
extraneous blank line
- rmudgett
On Sept. 23, 2014, 10:41 a.m., Jonathan Rose wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4013/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2014, 10:41 a.m.)
>
>
> Review request for Asterisk Developers and Matt Jordan.
>
>
> Bugs: ASTERISK-23781
> https://issues.asterisk.org/jira/browse/ASTERISK-23781
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> The SIP directmedia value 'outgoing' was overlooked when creating the table and \
> needs to be added. Unfortunately this means dropping the column and rebuilding it \
> with a new enum.
>
> Diffs
> -----
>
> /branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py \
> PRE-CREATION
> Diff: https://reviewboard.asterisk.org/r/4013/diff/
>
>
> Testing
> -------
>
> upgraded, checked to see if I could put 'outgoing' in the directmedia column. \
> Downgraded, upgraded again to make sure things didn't explode.
> All on a postgres database
>
>
> Thanks,
>
> Jonathan Rose
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4013/">https://reviewboard.asterisk.org/r/4013/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Minor nits
Before committing for each branch it's going into be sure to check if there are \
conflicts in the alembic node chain. \
https://wiki.asterisk.org/wiki/display/AST/Merging+alembic+scripts</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/4013/diff/2/?file=67542#file67542line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="sd">"""Add Outgoing enum value to sippeers \
directmedia</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should add \
the standard license header to the file.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/4013/diff/2/?file=67542#file67542line55" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">55</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">extraneous \
blank line</pre> </div>
<br />
<p>- rmudgett</p>
<br />
<p>On September 23rd, 2014, 10:41 a.m. CDT, Jonathan Rose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By Jonathan Rose.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2014, 10:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23781">ASTERISK-23781</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The SIP directmedia value 'outgoing' was overlooked when \
creating the table and needs to be added. Unfortunately this means dropping the \
column and rebuilding it with a new enum.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">upgraded, checked to see if I could put 'outgoing' in the \
directmedia column. Downgraded, upgraded again to make sure things didn't \
explode.
All on a postgres database</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4013/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic