[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2964: res_pjsip_outbound_registration: Add "virtual line" support f
From: "opticron" <reviewboard () asterisk ! org>
Date: 2014-09-30 20:03:18
Message-ID: 20140930200318.23427.18529 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2964/#review13418
-----------------------------------------------------------
/trunk/res/res_pjsip_outbound_registration.c
<https://reviewboard.asterisk.org/r/2964/#comment23942>
pj_create_random_string() does not NULL-terminate the buffer when generating the \
string. This should be taken care of manually and space allotted for the NULL \
terminator.
- opticron
On Sept. 13, 2014, 5:44 a.m., Joshua Colp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2964/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2014, 5:44 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This patch adds "virtual line" support to the res_pjsip_outbound_registration \
> module. This is an optional feature and simply adds a "line" URI parameter to the \
> Contact we place in the outbound registration. If this line parameter is present on \
> incoming requests we use it to establish a relationship to the outbound \
> registration and match it to a user configured endpoint. This has the benefit that \
> when registering to another server where it is supported you no longer have to do \
> IP based matching for all of their potential servers. The downside (and why this is \
> optional) is that if a third party got the line parameter they could send you calls \
> as if they were the legit remote server.
>
> Diffs
> -----
>
> /trunk/res/res_pjsip_outbound_registration.c 423063
> /trunk/configs/samples/pjsip.conf.sample 423063
>
> Diff: https://reviewboard.asterisk.org/r/2964/diff/
>
>
> Testing
> -------
>
> Registered to an ITSP, placed an inbound call from them, confirmed matched using \
> line parameter.
> Registered to a chan_sip instance, placed an inbound call from it, confirmed \
> matched using line parameter.
>
> Thanks,
>
> Joshua Colp
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2964/">https://reviewboard.asterisk.org/r/2964/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2964/diff/2/?file=67343#file67343line862" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/res/res_pjsip_outbound_registration.c</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
int sip_outbound_registration_regc_alloc(void *data)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">862</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span \
class="n">pj_create_random_string</span><span class="p">(</span><span \
class="n">registration</span><span class="o">-></span><span \
class="n">state</span><span class="o">-></span><span \
class="n">client_state</span><span class="o">-></span><span \
class="n">line</span><span class="p">,</span> <span class="k">sizeof</span><span \
class="p">(</span><span class="n">registration</span><span \
class="o">-></span><span class="n">state</span><span class="o">-></span><span \
class="n">client_state</span><span class="o">-></span><span \
class="n">line</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">pj_create_random_string() does not NULL-terminate the buffer when \
generating the string. This should be taken care of manually and space allotted for \
the NULL terminator.</pre> </div>
<br />
<p>- opticron</p>
<br />
<p>On September 13th, 2014, 5:44 a.m. CDT, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2014, 5:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds "virtual line" support to the \
res_pjsip_outbound_registration module. This is an optional feature and simply adds a \
"line" URI parameter to the Contact we place in the outbound registration. \
If this line parameter is present on incoming requests we use it to establish a \
relationship to the outbound registration and match it to a user configured endpoint. \
This has the benefit that when registering to another server where it is supported \
you no longer have to do IP based matching for all of their potential servers. The \
downside (and why this is optional) is that if a third party got the line parameter \
they could send you calls as if they were the legit remote server.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Registered to an ITSP, placed an inbound call from them, confirmed \
matched using line parameter.
Registered to a chan_sip instance, placed an inbound call from it, confirmed matched \
using line parameter.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_pjsip_outbound_registration.c <span style="color: \
grey">(423063)</span></li>
<li>/trunk/configs/samples/pjsip.conf.sample <span style="color: \
grey">(423063)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2964/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic