[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI comma
From: "opticron" <reviewboard () asterisk ! org>
Date: 2014-07-31 19:09:11
Message-ID: 20140731190911.14658.77980 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3797/#review12948
-----------------------------------------------------------
Ship it!
Go ahead and commit this as the code looks good to go. I'll take care of the \
documentation for it since PJSIPShowEndpoint is lacking enough in reponse \
documentation so as to be out of the scope of this review.
- opticron
On July 29, 2014, 3:05 p.m., Mark Michelson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3797/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 3:05 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This adds additional contact-specific output to PJSIPShowEndpoint output. For each \
> contact bound to an AOR, we print the AOR name, the contact URI, whether the \
> contact is reachable (or "Untracked" if not qualifying), and the roundtrip time for \
> qualification attempts.
>
> Diffs
> -----
>
> /trunk/res/res_pjsip/pjsip_options.c 419589
>
> Diff: https://reviewboard.asterisk.org/r/3797/diff/
>
>
> Testing
> -------
>
> I have created both tracked and untracked contacts and ensured that the output \
> looked correct for each.
>
> Thanks,
>
> Mark Michelson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3797/">https://reviewboard.asterisk.org/r/3797/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Go ahead and commit this \
as the code looks good to go. I'll take care of the documentation for it since \
PJSIPShowEndpoint is lacking enough in reponse documentation so as to be out of the \
scope of this review.</pre> <br />
<p>- opticron</p>
<br />
<p>On July 29th, 2014, 3:05 p.m. CDT, Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated July 29, 2014, 3:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds additional contact-specific output to PJSIPShowEndpoint \
output. For each contact bound to an AOR, we print the AOR name, the contact URI, \
whether the contact is reachable (or "Untracked" if not qualifying), and \
the roundtrip time for qualification attempts.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have created both tracked and untracked contacts and ensured that the \
output looked correct for each.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_pjsip/pjsip_options.c <span style="color: \
grey">(419589)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3797/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic