[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3679: WebRTC: Add SHA-256 support, change DTLS-SRTP negotiation, ad
From: "Joshua Colp" <reviewboard () asterisk ! org>
Date: 2014-06-30 19:42:25
Message-ID: 20140630194225.32038.93264 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3679/
-----------------------------------------------------------
(Updated June 30, 2014, 2:42 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
-------
Committed in revision 417677
Bugs: ASTERISK-22961 and ASTERISK-23026
https://issues.asterisk.org/jira/browse/ASTERISK-22961
https://issues.asterisk.org/jira/browse/ASTERISK-23026
Repository: Asterisk
Description
-------
This change does the following:
1. Adds SHA-256 support for DTLS-SRTP. This is done in an extensible way so if we \
need to add other hashes it should be relatively easy to. 2. Adds the ability to \
force "AVP" for DTLS streams for greater interoperability. 3. Sets the ICE role to \
controlled or controlling depending on offer/answer. 4. Provides the ability to \
verify only fingerprint, certificate, or both. 5. Adds DTLS negotiation to RTCP.
6. Changes DTLS negotiation to occur after ICE negotiation completes.
7. Adds handling of DTLS traffic before ICE negotiation has formally completed.
Diffs
-----
/branches/11/res/res_rtp_asterisk.c 417586
/branches/11/main/rtp_engine.c 417586
/branches/11/include/asterisk/rtp_engine.h 417586
/branches/11/configs/sip.conf.sample 417586
/branches/11/channels/sip/include/sip.h 417586
/branches/11/channels/chan_sip.c 417586
/branches/11/UPGRADE.txt 417586
Diff: https://reviewboard.asterisk.org/r/3679/diff/
Testing
-------
Tested inbound and outbound calls against:
Chrome
Yandex Browser
Opera
Maxthon
Firefox
Note that hold/unhold only currently works against Chrome based browsers.
Thanks,
Joshua Colp
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3679/">https://reviewboard.asterisk.org/r/3679/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated June 30, 2014, 2:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 417677</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22961">ASTERISK-22961</a>, \
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23026">ASTERISK-23026</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This change does the following:
1. Adds SHA-256 support for DTLS-SRTP. This is done in an extensible way so if we \
need to add other hashes it should be relatively easy to. 2. Adds the ability to \
force "AVP" for DTLS streams for greater interoperability. 3. Sets the ICE \
role to controlled or controlling depending on offer/answer. 4. Provides the ability \
to verify only fingerprint, certificate, or both. 5. Adds DTLS negotiation to RTCP.
6. Changes DTLS negotiation to occur after ICE negotiation completes.
7. Adds handling of DTLS traffic before ICE negotiation has formally completed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested inbound and outbound calls against:
Chrome
Yandex Browser
Opera
Maxthon
Firefox
Note that hold/unhold only currently works against Chrome based browsers.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/res/res_rtp_asterisk.c <span style="color: \
grey">(417586)</span></li>
<li>/branches/11/main/rtp_engine.c <span style="color: grey">(417586)</span></li>
<li>/branches/11/include/asterisk/rtp_engine.h <span style="color: \
grey">(417586)</span></li>
<li>/branches/11/configs/sip.conf.sample <span style="color: \
grey">(417586)</span></li>
<li>/branches/11/channels/sip/include/sip.h <span style="color: \
grey">(417586)</span></li>
<li>/branches/11/channels/chan_sip.c <span style="color: grey">(417586)</span></li>
<li>/branches/11/UPGRADE.txt <span style="color: grey">(417586)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3679/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic