[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3477: Japanese language patch for app_voicemail.c and say.c
From: "Kevin McCoy" <reviewboard () asterisk ! org>
Date: 2014-06-30 4:00:23
Message-ID: 20140630040023.29905.34842 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3477/
-----------------------------------------------------------
(Updated June 29, 2014, 11 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
-------
Committed in revision 417591
Bugs: ASTERISK-23324
https://issues.asterisk.org/jira/browse/ASTERISK-23324
Repository: Asterisk
Description
-------
Created new review request with proper diffs. Japanese language support patch for \
sound files in app_voicemail.c and say.c, depends on entire sound file package \
currently available in release candidate format as per \
https://issues.asterisk.org/jira/browse/ASTERISK-23324 \
https://www.dropbox.com/s/axu6gfnf9fh40hz/asterisk-core-sounds-ja-wav-and-patch.tgz
Word order and plurals, dates, counts in Japanese are all significantly different \
than English, hence the need for this patch. Tested working with Asterisk 12.
Here is the installation procedure from the README contained in the RC archive:
----------
Install Asterisk Sound Files:
mkdir /var/lib/asterisk/sounds/ja
cd /var/lib/asterisk/sounds/ja
wget http://downloads.asterisk.org/pub/telephony/sounds/asterisk-core-sounds-ja-gsm-current.tar.gz \
tar xvfz asterisk-core-sounds-ja-gsm-current.tar.gz
rm -f asterisk-core-sounds-ja-gsm-current.tar.gz
chown -R asterisk.asterisk /var/lib/asterisk/sounds/ja
How To Change Default SIP Channel Language to Japanese
Using Asterisk (vanilla):
vi /etc/asterisk/sip.conf
Edit language variable to:
language = ja
Using FreePBX:
On the FreePBX menu -> Settings -> Asterisk SIP Settings -> Advanced General Settings \
section -> Language field Set Language field to : ja
Install Japanese Patch:
Download Asterisk 12 source
Change directory to Asterisk 12 source folder
Download the patches for say.c and app_voicemail.c
patch -p0 < say.c.20140226.jp.patch
patch -p0 < app_voicemail.c.20140226.jp.patch
Compile Asterisk 12 source as usual
------
I'm happy to answer questions about the code.
Diffs
-----
/trunk/main/say.c 413007
/trunk/apps/app_voicemail.c 413007
Diff: https://reviewboard.asterisk.org/r/3477/diff/
Testing
-------
Fixed code with diff r2 as requested. Please double check and give feedback.
Thanks,
Kevin McCoy
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3477/">https://reviewboard.asterisk.org/r/3477/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin McCoy.</div>
<p style="color: grey;"><i>Updated June 29, 2014, 11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 417591</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-23324">ASTERISK-23324</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created new review request with proper diffs. Japanese language support \
patch for sound files in app_voicemail.c and say.c, depends on entire sound file \
package currently available in release candidate format as per \
https://issues.asterisk.org/jira/browse/ASTERISK-23324 \
https://www.dropbox.com/s/axu6gfnf9fh40hz/asterisk-core-sounds-ja-wav-and-patch.tgz
Word order and plurals, dates, counts in Japanese are all significantly different \
than English, hence the need for this patch. Tested working with Asterisk 12.
Here is the installation procedure from the README contained in the RC archive:
----------
Install Asterisk Sound Files:
mkdir /var/lib/asterisk/sounds/ja
cd /var/lib/asterisk/sounds/ja
wget http://downloads.asterisk.org/pub/telephony/sounds/asterisk-core-sounds-ja-gsm-current.tar.gz \
tar xvfz asterisk-core-sounds-ja-gsm-current.tar.gz
rm -f asterisk-core-sounds-ja-gsm-current.tar.gz
chown -R asterisk.asterisk /var/lib/asterisk/sounds/ja
How To Change Default SIP Channel Language to Japanese
Using Asterisk (vanilla):
vi /etc/asterisk/sip.conf
Edit language variable to:
language = ja
Using FreePBX:
On the FreePBX menu -> Settings -> Asterisk SIP Settings -> Advanced General \
Settings section -> Language field Set Language field to : ja
Install Japanese Patch:
Download Asterisk 12 source
Change directory to Asterisk 12 source folder
Download the patches for say.c and app_voicemail.c
patch -p0 < say.c.20140226.jp.patch
patch -p0 < app_voicemail.c.20140226.jp.patch
Compile Asterisk 12 source as usual
------
I'm happy to answer questions about the code.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed code with diff r2 as requested. Please double check and give \
feedback.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/say.c <span style="color: grey">(413007)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(413007)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3477/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic