'Re: [asterisk-dev] [Code Review] 3577: bridge_native_rtp: Use combined result of both channels to de'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 3577: bridge_native_rtp: Use combined result of both channels to de
From:       "Matt Jordan" <reviewboard () asterisk ! org>
Date:       2014-05-30 14:41:06
Message-ID: 20140530144106.7969.80014 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3577/#review12011
-----------------------------------------------------------

Ship it!

Ship It!

- Matt Jordan

On May 30, 2014, 8:58 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3577/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 8:58 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23541
> https://issues.asterisk.org/jira/browse/ASTERISK-23541
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The bridge_native_rtp module currently uses the bridge result of the first channel \
> that joins a bridge as the ultimate result. This means that if the first channel \
> has direct media enabled but the second does not a direct media bridge will still \
> occur. 
> This change makes it so that both sides are taken into account. If either side \
> forbids the bridge or responds with a local bridge result then either a generic or \
> local bridge occurs. 
> 
> Diffs
> -----
> 
> /branches/12/bridges/bridge_native_rtp.c 414813 
> 
> Diff: https://reviewboard.asterisk.org/r/3577/diff/
> 
> 
> Testing
> -------
> 
> Configured two SIP endpoints: caller with direct media enabled and callee with \
> direct media disabled. Placed a call from the caller to the callee. 
> Without this patch a reinvite occurs and the media is direct.
> With this patch no reinvite occurs and media is locally exchanged.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3577/">https://reviewboard.asterisk.org/r/3577/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Matt Jordan</p>

<br />
<p>On May 30th, 2014, 8:58 a.m. CDT, Joshua Colp wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>

<p style="color: grey;"><i>Updated May 30, 2014, 8:58 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-23541">ASTERISK-23541</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The bridge_native_rtp module currently uses the bridge result of the \
first channel that joins a bridge as the ultimate result. This means that if the \
first channel has direct media enabled but the second does not a direct media bridge \
will still occur.

This change makes it so that both sides are taken into account. If either side \
forbids the bridge or responds with a local bridge result then either a generic or \
local bridge occurs.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Configured two SIP endpoints: caller with direct media enabled and \
callee with direct media disabled. Placed a call from the caller to the callee.

Without this patch a reinvite occurs and the media is direct.
With this patch no reinvite occurs and media is locally exchanged.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/12/bridges/bridge_native_rtp.c <span style="color: \
grey">(414813)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3577/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 