[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3572: cli_aliases: Add 'pjsip reload' alias because it's nice. Plus
From: "Mark Michelson" <reviewboard () asterisk ! org>
Date: 2014-05-29 18:03:40
Message-ID: 20140529180340.26983.92705 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 28, 2014, 11:57 p.m., Paul Belanger wrote:
> > I'm all for adding the pjsip reload, but the context changes in the template seem \
> > unnecessary and potentially break systems that depend on the default config \
> > files.
>
> Matt Jordan wrote:
> Do you have an alternative to propose for naming Asterisk 12+ CLI aliases?
>
> rnewton wrote:
> Those syntax backwards compatibility templates are commented out in the config \
> sample file. Only the "friendly" template is enabled. No system should be dependent \
> on those.
[asterisk_twelve]
[asterisk_thirteen]
btw, I'm totally kidding.
I don't see how this would negatively affect systems.
First, this is a sample config; it's meant to be a sample of how things can be \
configured. IMO, it's something that is subject to change mid-release and should not \
affect running systems (do people really 'make samples' on an already installed and \
running system?).
Second, the change is entirely self-contained. The context names are being changed, \
and also the sample lines for enabling the sections are being changed. There is \
nothing outside of cli_aliases.conf that references this information. Someone who \
uses the sample config can just as easily uncomment the lines they care about as they \
could before.
- Mark
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3572/#review11989
-----------------------------------------------------------
On May 28, 2014, 8:14 p.m., rnewton wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3572/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 8:14 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: https://issues.asterisk.org/jira/browse/ASTERISK-23654
> https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-23654
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> 1. changed naming of included alias templates to avoid confusion between version \
> names. For example, asterisk12 was for asterisk 1.2, so I changed it to \
> asterisk_1dot2, so that later we can use asterisk_12 for Asterisk 12. 2. added \
> alias for "features reload" to the template for Asterisk 11 style syntax template, \
> as features reload was removed in 12, but you can still do "module reload features" \
> 3. added alias for "pjsip reload" to the friendly template. It is shorter than \
> "module reload res_pjsip.so" and if some are like me; I constantly forget that \
> reloading chan_pjsip doesn't parse config. Remembering "pjsip reload" is just \
> easier.
>
> Diffs
> -----
>
> /branches/12/configs/cli_aliases.conf.sample 414779
>
> Diff: https://reviewboard.asterisk.org/r/3572/diff/
>
>
> Testing
> -------
>
> Tested the added aliases.
>
>
> Thanks,
>
> rnewton
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3572/">https://reviewboard.asterisk.org/r/3572/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 28th, 2014, 11:57 p.m. UTC, <b>Paul \
Belanger</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm all for adding the pjsip reload, but the context changes in the \
template seem unnecessary and potentially break systems that depend on the default \
config files.</pre> </blockquote>
<p>On May 29th, 2014, 3:34 a.m. UTC, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you have an \
alternative to propose for naming Asterisk 12+ CLI aliases?</pre> </blockquote>
<p>On May 29th, 2014, 12:46 p.m. UTC, <b>rnewton</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Those syntax backwards \
compatibility templates are commented out in the config sample file. Only the \
"friendly" template is enabled. No system should be dependent on \
those.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[asterisk_twelve] \
[asterisk_thirteen]
btw, I'm totally kidding.
I don't see how this would negatively affect systems.
First, this is a sample config; it's meant to be a sample of how things can be \
configured. IMO, it's something that is subject to change mid-release and should \
not affect running systems (do people really 'make samples' on an already \
installed and running system?).
Second, the change is entirely self-contained. The context names are being changed, \
and also the sample lines for enabling the sections are being changed. There is \
nothing outside of cli_aliases.conf that references this information. Someone who \
uses the sample config can just as easily uncomment the lines they care about as they \
could before.</pre> <br />
<p>- Mark</p>
<br />
<p>On May 28th, 2014, 8:14 p.m. UTC, rnewton wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rnewton.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 8:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-23654">https://issues.asterisk.org/jira/browse/ASTERISK-23654</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. changed naming of included alias templates to avoid confusion between \
version names. For example, asterisk12 was for asterisk 1.2, so I changed it to \
asterisk_1dot2, so that later we can use asterisk_12 for Asterisk 12. 2. added alias \
for "features reload" to the template for Asterisk 11 style syntax \
template, as features reload was removed in 12, but you can still do "module \
reload features" 3. added alias for "pjsip reload" to the friendly \
template. It is shorter than "module reload res_pjsip.so" and if some are \
like me; I constantly forget that reloading chan_pjsip doesn't parse config. \
Remembering "pjsip reload" is just easier. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested the added aliases.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/configs/cli_aliases.conf.sample <span style="color: \
grey">(414779)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3572/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic