'Re: [asterisk-dev] [Code Review] 3473: res_pjsip_sdp_rtp: Add tests for receiving same SDP when call'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 3473: res_pjsip_sdp_rtp: Add tests for receiving same SDP when call
From:       "Joshua Colp" <reviewboard () asterisk ! org>
Date:       2014-04-30 15:45:22
Message-ID: 20140430154522.11222.16826 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3473/
-----------------------------------------------------------

(Updated April 30, 2014, 3:45 p.m.)

Review request for Asterisk Developers.

Bugs: ASTERISK-23558
    https://issues.asterisk.org/jira/browse/ASTERISK-23558

Repository: testsuite

Description
-------

This adds two additional scenario files to the PJSIP hold tests which send another \
INVITE and an UPDATE containing the same SDP that originally put the call on hold.

Diffs (updated)
-----

  /asterisk/trunk/tests/channels/pjsip/hold/sipp/phone_B_hold_update.xml PRE-CREATION \
  /asterisk/trunk/tests/channels/pjsip/hold/sipp/phone_B_duplicate_hold.xml \
PRE-CREATION   /asterisk/trunk/tests/channels/pjsip/hold/run-test 5006 

Diff: https://reviewboard.asterisk.org/r/3473/diff/

Testing
-------

Ran and confirmed happy (after fixes were applied).

Thanks,

Joshua Colp

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3473/">https://reviewboard.asterisk.org/r/3473/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>

<p style="color: grey;"><i>Updated April 30, 2014, 3:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-23558">ASTERISK-23558</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds two additional scenario files to the PJSIP hold tests which \
send another INVITE and an UPDATE containing the same SDP that originally put the \
call on hold.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran and confirmed happy (after fixes were applied).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/trunk/tests/channels/pjsip/hold/sipp/phone_B_hold_update.xml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/hold/sipp/phone_B_duplicate_hold.xml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/hold/run-test <span style="color: \
grey">(5006)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3473/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 