[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: [asterisk-dev] [Code Review] 3501: testsuite: add tests for ari userevents
From: "Scott Griepentrog" <reviewboard () asterisk ! org>
Date: 2014-04-29 19:27:25
Message-ID: 20140429192725.2282.64753 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3501/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-22697
https://issues.asterisk.org/jira/browse/ASTERISK-22697
Repository: testsuite
Description
-------
Tests added:
1) userevents/channel - check that the dialplan app Userevent() generated event \
produces correct ARI/AMI events
2) userevents/multi - check that various forms of the ARI userevent generate correct \
ARI & AMI events
3) userevents/invalid - check that correct result code is returned for invalid input \
cases
Changes to ari.py made to add expected: ### return code checking for HTTP requests.
Diffs
-----
/asterisk/trunk/tests/rest_api/applications/userevents/tests.yaml PRE-CREATION
/asterisk/trunk/tests/rest_api/applications/userevents/multi/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/userevents/multi/configs/ast1/pjsip.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/userevents/multi/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/userevents/invalid/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/userevents/invalid/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/userevents/channel/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/userevents/channel/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/rest_api/applications/tests.yaml 5006
/asterisk/trunk/lib/python/asterisk/ari.py 5006
Diff: https://reviewboard.asterisk.org/r/3501/diff/
Testing
-------
Tests pass with userevent code. Also tested with r3496 valgrind support to insure no \
invalid references.
Thanks,
Scott Griepentrog
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3501/">https://reviewboard.asterisk.org/r/3501/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Scott Griepentrog.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22697">ASTERISK-22697</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests added:
1) userevents/channel - check that the dialplan app Userevent() generated event \
produces correct ARI/AMI events
2) userevents/multi - check that various forms of the ARI userevent generate correct \
ARI & AMI events
3) userevents/invalid - check that correct result code is returned for invalid input \
cases
Changes to ari.py made to add expected: ### return code checking for HTTP \
requests.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tests pass with userevent code. Also tested with r3496 valgrind support \
to insure no invalid references.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/rest_api/applications/userevents/tests.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/userevents/multi/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/userevents/multi/configs/ast1/pjsip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/userevents/multi/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/userevents/invalid/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/userevents/invalid/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/userevents/channel/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/userevents/channel/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/rest_api/applications/tests.yaml <span style="color: \
grey">(5006)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ari.py <span style="color: \
grey">(5006)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3501/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic