[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3207: HEP: Add a Homer Encapsulation Protocol (HEP) v3 capture agen
From: "Matt Jordan" <reviewboard () asterisk ! org>
Date: 2014-03-28 18:09:09
Message-ID: 20140328180909.26134.6885 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3207/
-----------------------------------------------------------
(Updated March 28, 2014, 1:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers, Joshua Colp and Olle E Johansson.
Changes
-------
Committed in revision 411534
Repository: Asterisk
Description
-------
This patch adds the following:
(1) A new module, res_hep, which implements a generic packet capture agent for the \
Homer Encapsulation Protocol (HEP) version 3. Note that this code is heavily based on \
a patch provided by Alexandr Dubovikov; I basically just wrapped it up, added \
configuration via the configuration framework, and threw in a taskprocessor. (2) A \
new module, res_hep_pjsip, which performs packet capturing for the PJSIP SIP stack. \
This is one of those modules that I think really showcases how nice the new stack is \
- we're able to add a new module that inserts itself into the stack and forwards the \
message traffic off to the res_hep module without modifying the core parts of the \
stack itself. This means a system administrator could load this at will on certain \
Asterisk systems and - if the capturing isn't needed - unload it and keep the stack \
'slim'.
A few notes:
* This code exists in the following branch:
http://svn.asterisk.org/svn/asterisk/team/mjordan/12-hep
* The code in the branch also contains a module for RTCP. While that actually *does* \
send RTCP information over HEP, it does so as a JSON blob, which is not super useful. \
It's an open question as to what the formatting should be, i.e., a SNOM-esque \
encoding, RFC 6035, etc. I'm open to suggestions on this, which is why I deferred \
that functionality for a later review.
* Much thanks to Alexandr for his Asterisk patch for this code and for a *lot* of \
patience waiting for me to port it to 12/trunk. Due to some dithering on my part, \
this has taken the better part of a year to port forward (I still blame CDRs for the \
delay).
Diffs
-----
/branches/12/res/res_hep_pjsip.c PRE-CREATION
/branches/12/res/res_hep.exports.in PRE-CREATION
/branches/12/res/res_hep.c PRE-CREATION
/branches/12/include/asterisk/res_hep.h PRE-CREATION
/branches/12/configs/hep.conf.sample PRE-CREATION
/branches/12/CHANGES 407945
Diff: https://reviewboard.asterisk.org/r/3207/diff/
Testing
-------
An automated test that emulates a SIP capture server was written and is up for review \
here: https://reviewboard.asterisk.org/r/3206
This admittedly needs some *real* testing, as I have yet to stand up Kamailio with \
HEP. I think the code is far enough along to get some eyes on it however.
Thanks,
Matt Jordan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3207/">https://reviewboard.asterisk.org/r/3207/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, Joshua Colp and Olle E Johansson.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated March 28, 2014, 1:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 411534</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the following: (1) A new module, res_hep, which \
implements a generic packet capture agent for the Homer Encapsulation Protocol (HEP) \
version 3. Note that this code is heavily based on a patch provided by Alexandr \
Dubovikov; I basically just wrapped it up, added configuration via the configuration \
framework, and threw in a taskprocessor. (2) A new module, res_hep_pjsip, which \
performs packet capturing for the PJSIP SIP stack. This is one of those modules that \
I think really showcases how nice the new stack is - we're able to add a new \
module that inserts itself into the stack and forwards the message traffic off to the \
res_hep module without modifying the core parts of the stack itself. This means a \
system administrator could load this at will on certain Asterisk systems and - if the \
capturing isn't needed - unload it and keep the stack 'slim'.
A few notes:
* This code exists in the following branch:
http://svn.asterisk.org/svn/asterisk/team/mjordan/12-hep
* The code in the branch also contains a module for RTCP. While that actually *does* \
send RTCP information over HEP, it does so as a JSON blob, which is not super useful. \
It's an open question as to what the formatting should be, i.e., a SNOM-esque \
encoding, RFC 6035, etc. I'm open to suggestions on this, which is why I deferred \
that functionality for a later review.
* Much thanks to Alexandr for his Asterisk patch for this code and for a *lot* of \
patience waiting for me to port it to 12/trunk. Due to some dithering on my part, \
this has taken the better part of a year to port forward (I still blame CDRs for the \
delay).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">An automated test that emulates a SIP capture server was written and is \
up for review here: https://reviewboard.asterisk.org/r/3206
This admittedly needs some *real* testing, as I have yet to stand up Kamailio with \
HEP. I think the code is far enough along to get some eyes on it however.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_hep_pjsip.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/res_hep.exports.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/res_hep.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/branches/12/include/asterisk/res_hep.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/branches/12/configs/hep.conf.sample <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/branches/12/CHANGES <span style="color: grey">(407945)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3207/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic