[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3151: res_pjsip: PJSUA pluggable module and subscription tests
From: "Mark Michelson" <reviewboard () asterisk ! org>
Date: 2014-01-31 22:48:55
Message-ID: 20140131224855.29123.74787 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3151/
-----------------------------------------------------------
(Updated Jan. 31, 2014, 10:48 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Repository: testsuite
Description
-------
When creating the changes on https://reviewboard.asterisk.org/r/3150/, I realized \
that there were no subscription tests in the testsuite for res_pjsip yet.
In order to properly test subscriptions, I could not use SIPp, since removing the \
subscription requires the ability to handle two active transactions, and SIPp chokes \
when that happens. Since PJSUA is smarter and has python bindings, I decided to use \
that instead for the tests. In oder to do things the right way(tm), I decided to \
create a pluggable module for the testsuite that allows for PJSUA transports, \
accounts, and buddies to be created using yaml. Once all PJSUA accounts are \
registered, then a specified callback can be called to continue the test.
As far as actual tests are concerned, I've added three tests that use the new PJSUA \
plugin. There are two presence tests that test PIDF and XPIDF, and there is an MWI \
test. I was forced to use unsolicited MWI for the MWI test since the PJSUA python \
bindings do not have the ability to convey that an account should subscribe for MWI.
Diffs
-----
/asterisk/trunk/tests/channels/pjsip/tests.yaml 4618
/asterisk/trunk/tests/channels/pjsip/presence_xpidf/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/presence_xpidf/state_check.py PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/pjsip.conf \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/modules.conf \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/presence_pidf/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/presence_pidf/state_check.py \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/pjsip.conf \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/modules.conf \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/mwi/test-config.yaml PRE-CREATION \
/asterisk/trunk/tests/channels/pjsip/mwi/mwi_check.py PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/pjsip.conf PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/modules.conf PRE-CREATION
/asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4618
Diff: https://reviewboard.asterisk.org/r/3151/diff/
Testing
-------
The tests pass.
Thanks,
Mark Michelson
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3151/">https://reviewboard.asterisk.org/r/3151/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2014, 10:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When creating the changes on https://reviewboard.asterisk.org/r/3150/, I \
realized that there were no subscription tests in the testsuite for res_pjsip yet.
In order to properly test subscriptions, I could not use SIPp, since removing the \
subscription requires the ability to handle two active transactions, and SIPp chokes \
when that happens. Since PJSUA is smarter and has python bindings, I decided to use \
that instead for the tests. In oder to do things the right way(tm), I decided to \
create a pluggable module for the testsuite that allows for PJSUA transports, \
accounts, and buddies to be created using yaml. Once all PJSUA accounts are \
registered, then a specified callback can be called to continue the test.
As far as actual tests are concerned, I've added three tests that use the new \
PJSUA plugin. There are two presence tests that test PIDF and XPIDF, and there is an \
MWI test. I was forced to use unsolicited MWI for the MWI test since the PJSUA python \
bindings do not have the ability to convey that an account should subscribe for \
MWI.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The tests pass.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: \
grey">(4618)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/state_check.py <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/pjsip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/modules.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/state_check.py <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/pjsip.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/modules.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi/test-config.yaml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi/mwi_check.py <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/pjsip.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/modules.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/pluggable_modules.py <span style="color: \
grey">(4618)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3151/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic