[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3167: alembic: script modifications due to errors
From: "Kevin Harwell" <reviewboard () asterisk ! org>
Date: 2014-01-31 22:23:52
Message-ID: 20140131222352.30085.96214 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3167/
-----------------------------------------------------------
(Updated Jan. 31, 2014, 4:23 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Repository: Asterisk
Description
-------
A couple of the scripts had errors that would not allow a full migration to take \
place. The extensions table needed to make its 'id' column a primary key in order to \
work with mysql. The other script ...add_endpoints... was missing tables that it was \
trying to add columns to.
Added the primary key on id for extensions and added the tables in for the missing \
pjsip configuration options.
Diffs
-----
branches/12/contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py \
406846 branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py \
406846 branches/12/UPGRADE.txt 406846
Diff: https://reviewboard.asterisk.org/r/3167/diff/
Testing
-------
Ran the alembic scripts against postgres and mysql database servers to make sure \
everything was created correctly.
Thanks,
Kevin Harwell
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3167/">https://reviewboard.asterisk.org/r/3167/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2014, 4:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A couple of the scripts had errors that would not allow a full migration \
to take place. The extensions table needed to make its 'id' column a primary \
key in order to work with mysql. The other script ...add_endpoints... was missing \
tables that it was trying to add columns to.
Added the primary key on id for extensions and added the tables in for the missing \
pjsip configuration options. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran the alembic scripts against postgres and mysql database servers to \
make sure everything was created correctly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py \
<span style="color: grey">(406846)</span></li>
<li>branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py \
<span style="color: grey">(406846)</span></li>
<li>branches/12/UPGRADE.txt <span style="color: grey">(406846)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3167/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic