'Re: [asterisk-dev] [Code Review] 3164: res_pjsip_mwi: Subscribe fails when missing aor name'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 3164: res_pjsip_mwi: Subscribe fails when missing aor name
From:       "Kevin Harwell" <reviewboard () asterisk ! org>
Date:       2014-01-31 22:09:20
Message-ID: 20140131220920.29159.20044 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3164/
-----------------------------------------------------------

(Updated Jan. 31, 2014, 4:09 p.m.)

Status
------

This change has been marked as submitted.

Review request for Asterisk Developers.

Bugs: ASTERISK-23072
    https://issues.asterisk.org/jira/browse/ASTERISK-23072

Repository: Asterisk

Description
-------

When subscribing to MWI (res_pjsip_mwi) and the sip uri did not contain a name (ex: \
sip:<ip address>) then the subscription would fail since it would be unable to locate \
an associated aor.  This patch makes it so that when a subscribe comes with no aor \
name then it will subscribe to all aors on the located endpoint.

Diffs
-----

  branches/12/res/res_pjsip_mwi.c 406638 

Diff: https://reviewboard.asterisk.org/r/3164/diff/

Testing
-------

Some manual testing.  Set up an endpoint with two aors with two different mailboxes.  \
Made sure there were some messages waiting and then issued a subscribe without an aor \
name in the sip uri.  Noted the resulting notify had the correct number of new \
messages waiting.

Also setup a similar scenario in the testsuite: \
https://reviewboard.asterisk.org/r/3165/

Thanks,

Kevin Harwell

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3164/">https://reviewboard.asterisk.org/r/3164/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>

<p style="color: grey;"><i>Updated Jan. 31, 2014, 4:09 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-23072">ASTERISK-23072</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When subscribing to MWI (res_pjsip_mwi) and the sip uri did not contain \
a name (ex: sip:&lt;ip address&gt;) then the subscription would fail since it would \
be unable to locate an associated aor.  This patch makes it so that when a subscribe \
comes with no aor name then it will subscribe to all aors on the located \
endpoint.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some manual testing.  Set up an endpoint with two aors with two \
different mailboxes.  Made sure there were some messages waiting and then issued a \
subscribe without an aor name in the sip uri.  Noted the resulting notify had the \
correct number of new messages waiting.

Also setup a similar scenario in the testsuite: \
https://reviewboard.asterisk.org/r/3165/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/12/res/res_pjsip_mwi.c <span style="color: grey">(406638)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3164/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 