'Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 3168: PJSIP: Correct address to which ACK is sent in NAT situations
From:       "opticron" <reviewboard () asterisk ! org>
Date:       2014-01-31 15:05:23
Message-ID: 20140131150523.7511.29337 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3168/
-----------------------------------------------------------

(Updated Jan. 31, 2014, 9:05 a.m.)

Status
------

This change has been marked as submitted.

Review request for Asterisk Developers.

Bugs: ASTERISK-23106
    https://issues.asterisk.org/jira/browse/ASTERISK-23106

Repository: Asterisk

Description
-------

In NAT scenarios where a call is placed to a Grandstream phone, res_pjsip will \
sometimes send the ACK to a 200 OK to the private address of the device behind the \
NAT instead of the address of the NAT device. This corrects that behavior by \
rewriting the address in the Contact header in the incoming 200 OK and the dialog's \
target address if necessary (since it has already been rewritten to the incorrect \
private address).

Diffs
-----

  branches/12/res/res_pjsip_nat.c 406916 

Diff: https://reviewboard.asterisk.org/r/3168/diff/

Testing
-------

Manual testing and a new testsuite test at https://reviewboard.asterisk.org/r/3169/

Thanks,

opticron

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3168/">https://reviewboard.asterisk.org/r/3168/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>

<p style="color: grey;"><i>Updated Jan. 31, 2014, 9:05 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-23106">ASTERISK-23106</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In NAT scenarios where a call is placed to a Grandstream phone, \
res_pjsip will sometimes send the ACK to a 200 OK to the private address of the \
device behind the NAT instead of the address of the NAT device. This corrects that \
behavior by rewriting the address in the Contact header in the incoming 200 OK and \
the dialog&#39;s target address if necessary (since it has already been rewritten to \
the incorrect private address).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual testing and a new testsuite test at \
https://reviewboard.asterisk.org/r/3169/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/12/res/res_pjsip_nat.c <span style="color: grey">(406916)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3168/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 