[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target
From: "opticron" <reviewboard () asterisk ! org>
Date: 2014-01-30 22:21:39
Message-ID: 20140130222139.5115.92805 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3155/
-----------------------------------------------------------
(Updated Jan. 30, 2014, 4:21 p.m.)
Review request for Asterisk Developers.
Changes
-------
Address Matt's comments by adding deprecation warnings and upgrade text.
Bugs: PQ-1396
https://issues.asterisk.org/jira/browse/PQ-1396
Repository: Asterisk
Description
-------
Currently, when the first marked user enters the conference that contains waitmarked \
users, a prompt is played indicating that the user is being placed into the \
conference. Unfortunately, this prompt is played to the marked user and not the \
waitmarked users which is not very helpful.
This patch changes that behavior to play a prompt stating "The conference will now \
begin" to the entire conference after adding and unmuting the waitmarked users since \
the design of confbridge is not conducive to playing a prompt to a subset of users in \
a conference in an asynchronous manner.
Diffs (updated)
-----
branches/11/configs/confbridge.conf.sample 406782
branches/11/apps/confbridge/include/confbridge.h 406782
branches/11/apps/confbridge/conf_state_multi_marked.c 406782
branches/11/apps/confbridge/conf_state_empty.c 406782
branches/11/apps/confbridge/conf_config_parser.c 406782
branches/11/apps/app_confbridge.c 406782
branches/11/UPGRADE.txt 406782
Diff: https://reviewboard.asterisk.org/r/3155/diff/
Testing
-------
Verified that the prompt is heard by users already in the conference when a marked \
user enters and that ConfBridge tests pass with modified event expectations.
Thanks,
opticron
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3155/">https://reviewboard.asterisk.org/r/3155/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2014, 4:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Address Matt's comments by adding deprecation warnings and upgrade \
text.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/PQ-1396">PQ-1396</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, when the first marked user enters the conference that \
contains waitmarked users, a prompt is played indicating that the user is being \
placed into the conference. Unfortunately, this prompt is played to the marked user \
and not the waitmarked users which is not very helpful.
This patch changes that behavior to play a prompt stating "The conference will \
now begin" to the entire conference after adding and unmuting the waitmarked \
users since the design of confbridge is not conducive to playing a prompt to a subset \
of users in a conference in an asynchronous manner.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Verified that the prompt is heard by users already in the conference \
when a marked user enters and that ConfBridge tests pass with modified event \
expectations.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>branches/11/configs/confbridge.conf.sample <span style="color: \
grey">(406782)</span></li>
<li>branches/11/apps/confbridge/include/confbridge.h <span style="color: \
grey">(406782)</span></li>
<li>branches/11/apps/confbridge/conf_state_multi_marked.c <span style="color: \
grey">(406782)</span></li>
<li>branches/11/apps/confbridge/conf_state_empty.c <span style="color: \
grey">(406782)</span></li>
<li>branches/11/apps/confbridge/conf_config_parser.c <span style="color: \
grey">(406782)</span></li>
<li>branches/11/apps/app_confbridge.c <span style="color: grey">(406782)</span></li>
<li>branches/11/UPGRADE.txt <span style="color: grey">(406782)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3155/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic