'Re: [asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 3145: res_ari: Add event tests for blind and attended transfers
From:       "Mark Michelson" <reviewboard () asterisk ! org>
Date:       2014-01-30 19:40:42
Message-ID: 20140130194042.32681.15004 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3145/#review10719
-----------------------------------------------------------

Ship it!

Ship It!

- Mark Michelson

On Jan. 28, 2014, 3:55 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3145/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 3:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds tests for the blind and attended transfer events that are going to be added to ARI.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/bridges/tests.yaml 4610 
>   /asterisk/trunk/tests/rest_api/bridges/blind_transfer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/blind_transfer/blind_transfer.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3145/diff/
> 
> 
> Testing
> -------
> 
> Ran test, fails using branches. Applied patch for events and it passes!
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3145/">https://reviewboard.asterisk.org/r/3145/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Mark Michelson</p>

<br />
<p>On January 28th, 2014, 3:55 p.m. UTC, Joshua Colp wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>

<p style="color: grey;"><i>Updated Jan. 28, 2014, 3:55 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds tests for the blind and attended transfer events that are \
going to be added to ARI.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran test, fails using branches. Applied patch for events and it \
passes!</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/trunk/tests/rest_api/bridges/tests.yaml <span style="color: \
grey">(4610)</span></li>

 <li>/asterisk/trunk/tests/rest_api/bridges/blind_transfer/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/pjsip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/rest_api/bridges/blind_transfer/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/rest_api/bridges/blind_transfer/blind_transfer.py <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/rest_api/bridges/attended_transfer/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/pjsip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/rest_api/bridges/attended_transfer/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/rest_api/bridges/attended_transfer/attended_transfer.py \
<span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3145/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 