'Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2
From:       "George Joseph" <reviewboard () asterisk ! org>
Date:       2014-01-28 23:20:46
Message-ID: 20140128232046.7708.85259 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3104/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 4:20 p.m.)

Review request for Asterisk Developers.

Changes
-------

Added test for failed allocation in cli_print_identify_body.

Repository: Asterisk

Description
-------

Adds identify, transport and registration support to the CLI.
Creates 3 additional callbacks, one for an iterator, one for a comparator and one for \
a container.  This eliminates the link dependency from higher level modules to lower \
level ones. Eliminates duplicate sorting.
Cleans up output formatting.
Pushes cli registration down to the implementing source file.
Adds several ast_sip_destroy_sorcery functions to complement existing \
ast_sip_sorcery_initialize functions.  The destroy functions unregister cli commands \
and cli formatters.

Diffs (updated)
-----

  branches/12/res/res_pjsip_outbound_registration.c 406802 
  branches/12/res/res_pjsip_endpoint_identifier_ip.c 406802 
  branches/12/res/res_pjsip/pjsip_options.c 406802 
  branches/12/res/res_pjsip/pjsip_configuration.c 406802 
  branches/12/res/res_pjsip/pjsip_cli.c 406802 
  branches/12/res/res_pjsip/location.c 406802 
  branches/12/res/res_pjsip/include/res_pjsip_private.h 406802 
  branches/12/res/res_pjsip/config_transport.c 406802 
  branches/12/res/res_pjsip/config_global.c 406802 
  branches/12/res/res_pjsip/config_domain_aliases.c 406802 
  branches/12/res/res_pjsip/config_auth.c 406802 
  branches/12/include/asterisk/res_pjsip_cli.h 406802 
  branches/12/include/asterisk/res_pjsip.h 406802 

Diff: https://reviewboard.asterisk.org/r/3104/diff/

Testing
-------

Thanks,

George Joseph

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3104/">https://reviewboard.asterisk.org/r/3104/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By George Joseph.</div>

<p style="color: grey;"><i>Updated Jan. 28, 2014, 4:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added test for failed allocation in cli_print_identify_body. </pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds identify, transport and registration support to the CLI. Creates 3 \
additional callbacks, one for an iterator, one for a comparator and one for a \
container.  This eliminates the link dependency from higher level modules to lower \
level ones. Eliminates duplicate sorting.
Cleans up output formatting.
Pushes cli registration down to the implementing source file.
Adds several ast_sip_destroy_sorcery functions to complement existing \
ast_sip_sorcery_initialize functions.  The destroy functions unregister cli commands \
and cli formatters. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/12/res/res_pjsip_outbound_registration.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip_endpoint_identifier_ip.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip/pjsip_options.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip/pjsip_configuration.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip/pjsip_cli.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip/location.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip/include/res_pjsip_private.h <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip/config_transport.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip/config_global.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip/config_domain_aliases.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/res/res_pjsip/config_auth.c <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/include/asterisk/res_pjsip_cli.h <span style="color: \
grey">(406802)</span></li>

 <li>branches/12/include/asterisk/res_pjsip.h <span style="color: \
grey">(406802)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3104/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 