'Re: [asterisk-dev] [Code Review] 3094: res_pjsip_messaging: potential for field values in from/to he'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 3094: res_pjsip_messaging: potential for field values in from/to he
From:       "Kevin Harwell" <reviewboard () asterisk ! org>
Date:       2013-12-31 22:32:31
Message-ID: 20131231223231.16352.47634 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3094/
-----------------------------------------------------------

(Updated Dec. 31, 2013, 4:32 p.m.)

Review request for Asterisk Developers.

Changes
-------

Parts of the 'from' portion of the message were being overwritten by the \
pjsip_messaging module.  Removed the code causing problems.

Bugs: ASTERISK-22924
    https://issues.asterisk.org/jira/browse/ASTERISK-22924

Repository: Asterisk

Description
-------

Added in ability to specify display name format ("name" <sip:name@ipaddr:port>) for a \
given URI and made sure it was fully propagated to the outgoing message.  This mainly \
occurred when sending to a direct URI (using the default outbound endpoint).  \
MESSAGEs sent to/from a valid endpoint will use that endpoint's AOR/contact to fill \
in the appropriate information.

Diffs (updated)
-----

  branches/12/res/res_pjsip_messaging.c 404606 

Diff: https://reviewboard.asterisk.org/r/3094/diff/

Testing
-------

Some manual testing and also ran the current testsuite tests that exists to make sure \
everything still worked as expected.

Thanks,

Kevin Harwell

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3094/">https://reviewboard.asterisk.org/r/3094/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>

<p style="color: grey;"><i>Updated Dec. 31, 2013, 4:32 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Parts of the &#39;from&#39; portion of the message were being \
overwritten by the pjsip_messaging module.  Removed the code causing problems.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-22924">ASTERISK-22924</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added in ability to specify display name format (&quot;name&quot; \
&lt;sip:name@ipaddr:port&gt;) for a given URI and made sure it was fully propagated \
to the outgoing message.  This mainly occurred when sending to a direct URI (using \
the default outbound endpoint).  MESSAGEs sent to/from a valid endpoint will use that \
endpoint&#39;s AOR/contact to fill in the appropriate information.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some manual testing and also ran the current testsuite tests that exists \
to make sure everything still worked as expected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/12/res/res_pjsip_messaging.c <span style="color: \
grey">(404606)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3094/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 