[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3095: chan_pjsip: add 'set_var' support on endpoints
From: "Matt Jordan" <reviewboard () asterisk ! org>
Date: 2013-12-31 19:59:41
Message-ID: 20131231195941.15323.89273 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3095/#review10496
-----------------------------------------------------------
Ship it!
Ship It!
- Matt Jordan
On Dec. 27, 2013, 5:28 p.m., Kevin Harwell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3095/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2013, 5:28 p.m.)
>
>
> Review request for Asterisk Developers and Joshua Colp.
>
>
> Bugs: ASTERISK-22868
> https://issues.asterisk.org/jira/browse/ASTERISK-22868
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Added a new 'set_var' option for ast_sip_endpoint(s). For each variable specified \
> that variable gets set upon creation of a pjsip channel involving the endpoint.
>
> Diffs
> -----
>
> branches/12/res/res_pjsip/pjsip_configuration.c 404578
> branches/12/res/res_pjsip.c 404578
> branches/12/include/asterisk/res_pjsip.h 404578
> branches/12/configs/pjsip.conf.sample 404578
> branches/12/channels/chan_pjsip.c 404578
>
> Diff: https://reviewboard.asterisk.org/r/3095/diff/
>
>
> Testing
> -------
>
> Manual testing. Testsuite test to come.
>
>
> Thanks,
>
> Kevin Harwell
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3095/">https://reviewboard.asterisk.org/r/3095/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Matt Jordan</p>
<br />
<p>On December 27th, 2013, 5:28 p.m. CST, Kevin Harwell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and Joshua Colp.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2013, 5:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22868">ASTERISK-22868</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added a new 'set_var' option for ast_sip_endpoint(s). For each \
variable specified that variable gets set upon creation of a pjsip channel involving \
the endpoint.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manual testing. Testsuite test to come.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/res/res_pjsip/pjsip_configuration.c <span style="color: \
grey">(404578)</span></li>
<li>branches/12/res/res_pjsip.c <span style="color: grey">(404578)</span></li>
<li>branches/12/include/asterisk/res_pjsip.h <span style="color: \
grey">(404578)</span></li>
<li>branches/12/configs/pjsip.conf.sample <span style="color: \
grey">(404578)</span></li>
<li>branches/12/channels/chan_pjsip.c <span style="color: grey">(404578)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3095/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic