'[asterisk-dev] [Code Review] 3098: compiler warnings'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] [Code Review] 3098: compiler warnings
From:       "Kevin Harwell" <reviewboard () asterisk ! org>
Date:       2013-12-31 18:05:46
Message-ID: 20131231180546.10674.68346 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3098/
-----------------------------------------------------------

Review request for Asterisk Developers and Matt Jordan.

Repository: Asterisk

Description
-------

Fixed a couple of compiler warnings (errors in 'dev-mode') given by gcc version 4.8.1 \
(on Ubuntu).  The one in app_meetme involved the 'sizeof-pointer-memaccess' (see: \
http://gcc.gnu.org/gcc-4.8/porting_to.html) warning.  The one in chan_unistim was \
issuing an array out of bounds message.  Fixed both so they would no longer issue \
warnings and can compile again in 'dev-mode'.

Diffs
-----

  branches/1.8/channels/chan_unistim.c 404591 
  branches/1.8/apps/app_meetme.c 404591 

Diff: https://reviewboard.asterisk.org/r/3098/diff/

Testing
-------

Thanks,

Kevin Harwell

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3098/">https://reviewboard.asterisk.org/r/3098/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By Kevin Harwell.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed a couple of compiler warnings (errors in &#39;dev-mode&#39;) given \
by gcc version 4.8.1 (on Ubuntu).  The one in app_meetme involved the \
&#39;sizeof-pointer-memaccess&#39; (see: http://gcc.gnu.org/gcc-4.8/porting_to.html) \
warning.  The one in chan_unistim was issuing an array out of bounds message.  Fixed \
both so they would no longer issue warnings and can compile again in \
&#39;dev-mode&#39;.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/1.8/channels/chan_unistim.c <span style="color: \
grey">(404591)</span></li>

 <li>branches/1.8/apps/app_meetme.c <span style="color: grey">(404591)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3098/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 