'Re: [asterisk-dev] [Code Review] 3062: a systemd service'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 3062: a systemd service
From:       "Tzafrir Cohen" <reviewboard () asterisk ! org>
Date:       2013-12-24 16:49:04
Message-ID: 20131224164904.23720.16131 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3062/
-----------------------------------------------------------

(Updated Dec. 24, 2013, 4:49 p.m.)

Review request for Asterisk Developers.

Changes
-------

Now the unit itself is included.

Repository: Asterisk

Description
-------

Installs a systemd service file for Asterisk.

Systeemd is the new "one daemon to rule them all" for Linux: \
http://www.freedesktop.org/wiki/Software/systemd/ On systems without systemd this \
should be just a harmless (though maybe annoying) text file.

This is aimed at replacing safe_asterisk with a more reliable main loop. It almost \
does that. Is still fails to handle failures, as it seems that systemd's ExecPostStop \
command does not get the exist status of the stopped command.

Diffs (updated)
-----

  /trunk/contrib/asterisk.service PRE-CREATION 
  /trunk/Makefile 404563 

Diff: https://reviewboard.asterisk.org/r/3062/diff/

Testing
-------

Thanks,

Tzafrir Cohen

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3062/">https://reviewboard.asterisk.org/r/3062/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Tzafrir Cohen.</div>

<p style="color: grey;"><i>Updated Dec. 24, 2013, 4:49 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now the unit itself is included.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Installs a systemd service file for Asterisk.

Systeemd is the new &quot;one daemon to rule them all&quot; for Linux: \
http://www.freedesktop.org/wiki/Software/systemd/ On systems without systemd this \
should be just a harmless (though maybe annoying) text file.

This is aimed at replacing safe_asterisk with a more reliable main loop. It almost \
does that. Is still fails to handle failures, as it seems that systemd&#39;s \
ExecPostStop command does not get the exist status of the stopped command.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/contrib/asterisk.service <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>/trunk/Makefile <span style="color: grey">(404563)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3062/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 