[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.
From: "rmudgett" <reviewboard () asterisk ! org>
Date: 2013-12-20 4:37:37
Message-ID: 20131220043737.2302.32232 () sonic ! digium ! api
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/
-----------------------------------------------------------
(Updated Dec. 20, 2013, 4:37 a.m.)
Review request for Asterisk Developers.
Changes
-------
Fixed compile warning when MWI_DEBUG_CLI not defined.
Repository: Asterisk
Description
-------
This patch can be broken into two main components:
1) The core resource support for external MWI providers are in the following files:
apps/app_voicemail.c,
include/asterisk/res_mwi_external.h,
configs/sorcery.conf.sample,
res/res_mwi_external.c, and
res/res_mwi_external.exports.in.
* The core external MWI resource provides for MWI message counts persistence using \
sorcery. With sorcery, the user is able to configure which sorcery wizzard backend \
to use if the default astdb is not desired.
* The core external MWI resoruce provides some debugging CLI commands enabled by \
defining MWI_DEBUG_CLI. The debugging CLI commands are:
"mwi delete all",
"mwi delete like <regex>",
"mwi delete mailbox <mailbox>",
"mwi list all",
"mwi list like <regex>",
"mwi show mailbox <mailbox>", and
"mwi update mailbox <mailbox> [<new> [<old>]]".
2) The AMI component of external MWI is in:
res/res_mwi_external_ami.c
* The external MWI AMI interface provides a thin wrapper around the core external MWI \
resource. The resource adds the following AMI actions:
MWIGet,
MWIDelete, and
MWIUpdate.
Diffs (updated)
-----
/trunk/res/res_mwi_external_ami.c PRE-CREATION
/trunk/res/res_mwi_external.exports.in PRE-CREATION
/trunk/res/res_mwi_external.c PRE-CREATION
/trunk/include/asterisk/res_mwi_external.h PRE-CREATION
/trunk/configs/sorcery.conf.sample 404401
/trunk/apps/app_voicemail.c 404401
Diff: https://reviewboard.asterisk.org/r/3061/diff/
Testing
-------
Used the CLI "database show" along with the new CLI commands and AMI actions to test \
adding/updating, getting, and deleting external MWI counts.
Thanks,
rmudgett
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3061/">https://reviewboard.asterisk.org/r/3061/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2013, 4:37 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed compile warning when MWI_DEBUG_CLI not defined.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch can be broken into two main components:
1) The core resource support for external MWI providers are in the following files:
apps/app_voicemail.c,
include/asterisk/res_mwi_external.h,
configs/sorcery.conf.sample,
res/res_mwi_external.c, and
res/res_mwi_external.exports.in.
* The core external MWI resource provides for MWI message counts persistence using \
sorcery. With sorcery, the user is able to configure which sorcery wizzard backend \
to use if the default astdb is not desired.
* The core external MWI resoruce provides some debugging CLI commands enabled by \
defining MWI_DEBUG_CLI. The debugging CLI commands are:
"mwi delete all",
"mwi delete like <regex>",
"mwi delete mailbox <mailbox>",
"mwi list all",
"mwi list like <regex>",
"mwi show mailbox <mailbox>", and
"mwi update mailbox <mailbox> [<new> [<old>]]".
2) The AMI component of external MWI is in:
res/res_mwi_external_ami.c
* The external MWI AMI interface provides a thin wrapper around the core external MWI \
resource. The resource adds the following AMI actions:
MWIGet,
MWIDelete, and
MWIUpdate.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used the CLI "database show" along with the new CLI commands \
and AMI actions to test adding/updating, getting, and deleting external MWI \
counts.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_mwi_external_ami.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_mwi_external.exports.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_mwi_external.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/include/asterisk/res_mwi_external.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/configs/sorcery.conf.sample <span style="color: \
grey">(404401)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(404401)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3061/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic