'[asterisk-dev] [Code Review] 3083: funcs: REPLACE() can call strcpy on overlapping memory'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] [Code Review] 3083: funcs: REPLACE() can call strcpy on overlapping memory
From:       "Scott Griepentrog" <reviewboard () asterisk ! org>
Date:       2013-12-19 20:02:38
Message-ID: 20131219200238.17043.96241 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3083/
-----------------------------------------------------------

Review request for Asterisk Developers.

Bugs: ASTERISK-22910
    https://issues.asterisk.org/jira/browse/ASTERISK-22910

Repository: Asterisk

Description
-------

Patch by: Gareth Palmer

When calling REPLACE() with an empty replace-char argument; strcpy is used to \
overwrite the the matching <find-char>.

However as the src and dest argument to strcpy must not overlap it causes other parts \
of the string to be overwritten with adjacent characters and the result is mangled.

Patch replaces call to strcpy with memmove and adds a test suite case for REPLACE.

Diffs
-----

  /branches/1.8/funcs/func_strings.c 404386 

Diff: https://reviewboard.asterisk.org/r/3083/diff/

Testing
-------

Thanks,

Scott Griepentrog

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3083/">https://reviewboard.asterisk.org/r/3083/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Scott Griepentrog.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-22910">ASTERISK-22910</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch by: Gareth Palmer

When calling REPLACE() with an empty replace-char argument; strcpy is used to \
overwrite the the matching &lt;find-char&gt;.

However as the src and dest argument to strcpy must not overlap it causes other parts \
of the string to be overwritten with adjacent characters and the result is mangled.

Patch replaces call to strcpy with memmove and adds a test suite case for \
REPLACE.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/1.8/funcs/func_strings.c <span style="color: \
grey">(404386)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3083/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 