'Re: [asterisk-dev] [Code Review] 3022: res_pjsip: Respect outbound proxy in more places'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 3022: res_pjsip: Respect outbound proxy in more places
From:       "Joshua Colp" <reviewboard () asterisk ! org>
Date:       2013-11-26 20:14:40
Message-ID: 20131126201440.25215.58495 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3022/
-----------------------------------------------------------

(Updated Nov. 26, 2013, 8:14 p.m.)

Review request for Asterisk Developers.

Bugs: ASTERISK-22673
    https://issues.asterisk.org/jira/browse/ASTERISK-22673

Repository: Asterisk

Description
-------

There are currently cases where the outbound proxy is not available to be set or is \
not obeyed. The attached change fixes this.

1. An outbound proxy can now be specified on the AOR for qualify purposes if wanted.
2. An outbound proxy specified on the endpoint is now respected when out-of-dialog \
requests are created.

Diffs (updated)
-----

  /branches/12/res/res_pjsip/pjsip_options.c 403158 
  /branches/12/res/res_pjsip/location.c 403158 
  /branches/12/res/res_pjsip.c 403158 
  /branches/12/include/asterisk/res_pjsip.h 403158 

Diff: https://reviewboard.asterisk.org/r/3022/diff/

Testing
-------

Set the option, confirmed it was used.

Thanks,

Joshua Colp

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/3022/">https://reviewboard.asterisk.org/r/3022/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2013, 8:14 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-22673">ASTERISK-22673</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There are currently cases where the outbound proxy is not available to \
be set or is not obeyed. The attached change fixes this.

1. An outbound proxy can now be specified on the AOR for qualify purposes if wanted.
2. An outbound proxy specified on the endpoint is now respected when out-of-dialog \
requests are created.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Set the option, confirmed it was used.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/12/res/res_pjsip/pjsip_options.c <span style="color: \
grey">(403158)</span></li>

 <li>/branches/12/res/res_pjsip/location.c <span style="color: \
grey">(403158)</span></li>

 <li>/branches/12/res/res_pjsip.c <span style="color: grey">(403158)</span></li>

 <li>/branches/12/include/asterisk/res_pjsip.h <span style="color: \
grey">(403158)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/3022/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 