'Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events
From:       "Kevin Harwell" <reviewboard () asterisk ! org>
Date:       2013-11-23 17:14:31
Message-ID: 20131123171431.13761.97712 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2959/
-----------------------------------------------------------

(Updated Nov. 23, 2013, 11:14 a.m.)

Status
------

This change has been marked as submitted.

Review request for Asterisk Developers.

Changes
-------

Committed in revision 403131

Bugs: ASTERISK-22609
    https://issues.asterisk.org/jira/browse/ASTERISK-22609

Repository: Asterisk

Description
-------

Created the following AMI commands and corresponding events for res_pjsip:

PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few select \
attributes on each.  Events:
    EndpointList - for each endpoint a few attributes
    EndpointlistComplete - after all endpoints have been listed

PJSIPShowEndpoint - Provides a detail list of attributes for a specified endpoint
  Events:
    EndpointDetail - attributes on an endpoint
    AorDetail - raised for each AOR on an endpoint
    AuthDetail - raised for each associated inbound and outbound auth
    TransportDetail - transport attributes
    IdentifyDetail - attributes for the identify object associated with the endpoint
    EndpointDetailComplete - last event raised after all detail events

PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound \
registrations  Events:
    InboundRegistrationDetail - inbound registration attributes for each registration
    InboundRegistrationDetailComplete - raised after all detail records have been \
listed

PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound \
registrations  Events:
    OutboundRegistrationDetail - outbound registration attributes for each \
registration  OutboundRegistrationDetailComplete - raised after all detail records \
have been listed

PJSIPShowSubscriptions - A detail listing of all subscriptions and their attributes
  Events:
    SubscriptionDetail - on each subscription detailed attributes
    SubscriptionDetailComplete - raised after all detail records have been listed

Diffs
-----

  branches/12/res/res_pjsip_registrar.c 403083 
  branches/12/res/res_pjsip_pubsub.c 403083 
  branches/12/res/res_pjsip_outbound_registration.c 403083 
  branches/12/res/res_pjsip_mwi.c 403083 
  branches/12/res/res_pjsip_exten_state.c 403083 
  branches/12/res/res_pjsip_endpoint_identifier_ip.c 403083 
  branches/12/res/res_pjsip/pjsip_configuration.c 403083 
  branches/12/res/res_pjsip/location.c 403083 
  branches/12/res/res_pjsip/include/res_pjsip_private.h 403083 
  branches/12/res/res_pjsip/config_transport.c 403083 
  branches/12/res/res_pjsip/config_auth.c 403083 
  branches/12/res/res_pjsip.exports.in 403083 
  branches/12/res/res_pjsip.c 403083 
  branches/12/main/utils.c 403083 
  branches/12/main/sorcery.c 403083 
  branches/12/main/acl.c 403083 
  branches/12/include/asterisk/utils.h 403083 
  branches/12/include/asterisk/strings.h 403083 
  branches/12/include/asterisk/sorcery.h 403083 
  branches/12/include/asterisk/res_pjsip_pubsub.h 403083 
  branches/12/include/asterisk/res_pjsip.h 403083 
  branches/12/include/asterisk/acl.h 403083 

Diff: https://reviewboard.asterisk.org/r/2959/diff/

Testing
-------

Ran a few manual tests over AMI and observed the output to make sure things look \
correct.  Also wrote some testsuite tests: https://reviewboard.asterisk.org/r/2958/

Thanks,

Kevin Harwell

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2959/">https://reviewboard.asterisk.org/r/2959/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>

<p style="color: grey;"><i>Updated Nov. 23, 2013, 11:14 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 403131</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-22609">ASTERISK-22609</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created the following AMI commands and corresponding events for \
res_pjsip:

PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few select \
attributes on each.  Events:
    EndpointList - for each endpoint a few attributes
    EndpointlistComplete - after all endpoints have been listed

PJSIPShowEndpoint - Provides a detail list of attributes for a specified endpoint
  Events:
    EndpointDetail - attributes on an endpoint
    AorDetail - raised for each AOR on an endpoint
    AuthDetail - raised for each associated inbound and outbound auth
    TransportDetail - transport attributes
    IdentifyDetail - attributes for the identify object associated with the endpoint
    EndpointDetailComplete - last event raised after all detail events

PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound \
registrations  Events:
    InboundRegistrationDetail - inbound registration attributes for each registration
    InboundRegistrationDetailComplete - raised after all detail records have been \
listed

PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound \
registrations  Events:
    OutboundRegistrationDetail - outbound registration attributes for each \
registration  OutboundRegistrationDetailComplete - raised after all detail records \
have been listed

PJSIPShowSubscriptions - A detail listing of all subscriptions and their attributes
  Events:
    SubscriptionDetail - on each subscription detailed attributes
    SubscriptionDetailComplete - raised after all detail records have been \
listed</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran a few manual tests over AMI and observed the output to make sure \
things look correct.  Also wrote some testsuite tests: \
https://reviewboard.asterisk.org/r/2958/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/12/res/res_pjsip_registrar.c <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip_pubsub.c <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip_outbound_registration.c <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip_mwi.c <span style="color: grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip_exten_state.c <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip_endpoint_identifier_ip.c <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip/pjsip_configuration.c <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip/location.c <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip/include/res_pjsip_private.h <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip/config_transport.c <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip/config_auth.c <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip.exports.in <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/res/res_pjsip.c <span style="color: grey">(403083)</span></li>

 <li>branches/12/main/utils.c <span style="color: grey">(403083)</span></li>

 <li>branches/12/main/sorcery.c <span style="color: grey">(403083)</span></li>

 <li>branches/12/main/acl.c <span style="color: grey">(403083)</span></li>

 <li>branches/12/include/asterisk/utils.h <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/include/asterisk/strings.h <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/include/asterisk/sorcery.h <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/include/asterisk/res_pjsip_pubsub.h <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/include/asterisk/res_pjsip.h <span style="color: \
grey">(403083)</span></li>

 <li>branches/12/include/asterisk/acl.h <span style="color: \
grey">(403083)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2959/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 