'Re: [asterisk-dev] [Code Review] 2979: ari: Fix deadlock when originating multiple calls at once'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 2979: ari: Fix deadlock when originating multiple calls at once
From:       "Mark Michelson" <reviewboard () asterisk ! org>
Date:       2013-10-31 21:35:49
Message-ID: 20131031213549.25110.66904 () sonic ! digium ! api
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2979/#review10082
-----------------------------------------------------------

Ship it!

I suggest adding documentation to stasis_app_subscribe() to not have any channels \
locked when calling the function.

- Mark Michelson

On Oct. 31, 2013, 1:48 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2979/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 1:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22768
> https://issues.asterisk.org/jira/browse/ASTERISK-22768
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently when a stasis application is specified when originating using ARI the \
> application is subscribed to the originated channel. This is done while the channel \
> lock is held, which is dangerous as the underlying code locks and iterates the \
> channels container. The attached change releases the lock after getting a snapshot \
> of the originated channel. 
> 
> Diffs
> -----
> 
> /branches/12/res/ari/resource_channels.c 402138 
> 
> Diff: https://reviewboard.asterisk.org/r/2979/diff/
> 
> 
> Testing
> -------
> 
> Threw 10 originates at a time as fast as possible using ARI origination. Without \
> patch there was a deadlock sporadically, with patch no deadlock. 
> 
> Thanks,
> 
> Joshua Colp
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2979/">https://reviewboard.asterisk.org/r/2979/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I suggest adding \
documentation to stasis_app_subscribe() to not have any channels locked when calling \
the function.

</pre>
 <br />

<p>- Mark</p>

<br />
<p>On October 31st, 2013, 1:48 p.m. UTC, Joshua Colp wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>

<p style="color: grey;"><i>Updated Oct. 31, 2013, 1:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-22768">ASTERISK-22768</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently when a stasis application is specified when originating using \
ARI the application is subscribed to the originated channel. This is done while the \
channel lock is held, which is dangerous as the underlying code locks and iterates \
the channels container. The attached change releases the lock after getting a \
snapshot of the originated channel.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Threw 10 originates at a time as fast as possible using ARI origination. \
Without patch there was a deadlock sporadically, with patch no deadlock.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/12/res/ari/resource_channels.c <span style="color: \
grey">(402138)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2979/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 